Feature/22998 pdf password handling #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioh8010
reviewed
Dec 6, 2023
|
Works good! Screen.Recording.2023-12-11.at.6.57.47.AM.mov |
allroundexperts
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The PR introduces password handling for protected pdf files. Also, starting from this PR, the
example/starts using react-fast-pdf directly from NPM.Related Issues
Expensify/App#22998
Manual Tests
For testing locally and running in development mode, you need do a couple steps:
example/package.jsonchangereact-fast-pdfvalue to"../src".example/tsconfig.jsonchangerootDirvalue to"../".Linked PRs
N/A
PDF.mov