Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvmrc and node version in package.json #4

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

AndrewGable
Copy link
Contributor

Details

Fixes error as seen on first deploy: https://github.com/Expensify/react-fast-pdf/actions/runs/6787495471/job/18450423581

Related Issues

Expensify/App#22998

Manual Tests

  1. Merge PR
  2. Make sure it gets deployed to npm

Linked PRs

#3

@AndrewGable AndrewGable self-assigned this Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@AndrewGable
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mountiny mountiny merged commit f79351a into main Nov 7, 2023
2 checks passed
@AndrewGable AndrewGable deleted the andrew-node-version branch November 7, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants