Improve offline behaviour #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/22998-improve-offline-behaviour
MrRefactor
reviewed
Mar 6, 2024
This was referenced Mar 6, 2024
|
Works good! Screen.Recording.2024-03-11.at.11.42.00.PM.movScreen.Recording.2024-03-11.at.11.42.52.PM.movScreen.Recording.2024-03-11.at.11.45.57.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The PR improves the offline behavior. It handles to pre-upload of a PDF worker to be able to open PDF files smoothly when the user is offline. It was mentioned here. I use this PDF worker described in docs. Also, it improves the example project to be able to upload and open PDF files.
Related Issues
Expensify/App#22998
Manual Tests
npm install && cd example && npm install && cd ...cd example && npm run start && cd ..- of the example.Linked PRs
Expensify/App#33434
Offline.mp4
Offline.mp4