Handle cases without currency symbols #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Li357 QQ: Did you confirm if those 2 issues are no longer reproducible? |
|
Just confirmed https://github.com/Expensify/Expensify/issues/309211 is no longer producible, https://github.com/Expensify/Expensify/issues/309227 seems a little longer to set up |
|
@techievivek Verified both are not reproducible! |
|
I confirmed the other one is not reproducible with this change. |
techievivek
approved these changes
Aug 21, 2023
|
@Li357 Let's bump the new version in Web-E and I can CP that to staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/309211
$ https://github.com/Expensify/Expensify/issues/309227
Tests
Added two unit tests to test cases without currency symbols and without passing a currency string at all.
QA
Run the QA steps in the linked issues and verify that the error does not occur.