Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log search links are appending ?authToken= to the end, completely breaking them when navigating to them #9416

Closed
mvtglobally opened this issue Jun 13, 2022 · 2 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Send a log search link to someone IE https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=10000&query=blob%3A%22Expensiworks_CaptureAgentActivity%22%20AND%20blob%3A%22isDoneWorking%3A%20'true'%22%20AND%20email%3A%22monte%40expensify.com%22%20AND%20timestamp%3A%5B2022-05-25T12%3A00%20TO%202022-05-25T14%3A00%5D
  2. Click the link
  3. Observe ?authToken=&email= at the end of the link

Expected Result:

Log Search link should open without any issue

Actual Result:

Log search links are appending ?authToken= to the end, completely breaking them when navigating to them

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen Shot 2022-06-13 at 12 38 57 AM

Expensify/Expensify Issue URL:
Issue reported by: @alex-mechler
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2022

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@johnmlee101
Copy link
Contributor

This is coming from

return `${CONFIG.EXPENSIFY.EXPENSIFY_URL}${url}${url.indexOf('?') === -1 ? '?' : '&'}authToken=${shortLivedAuthToken}&email=${encodeURIComponent(currentUserEmail)}`;

since we don't have ? in the URL so it wants to append more just as is.

@johnmlee101 johnmlee101 added the Improvement Item broken or needs improvement. label Jun 14, 2022
@johnmlee101 johnmlee101 added the Reviewing Has a PR in review label Jun 14, 2022
@melvin-bot melvin-bot bot closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants