Wrapping Text inside Tooltip or Pressable make the text vertically misaligned on native - reported by @Tushu17

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to ReportWelcomText.js file
2. Wrap the Text inside Tooltip or Pressable
   

   App/src/components/ReportWelcomeText.js

   Lines 122 to 124 in ffe26f9

   	<Text style={[styles.textStrong]}>
   	{displayName}
   	</Text>

3. Open a chat with someone and check the welcome message

Expected Result:

It shouldn't get misaligned

Actual Result:

It gets misaligned

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number:
Reproducible in staging?: need repro
Reproducible in production?: need repro
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1651084914620279

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Tushu17]

@chiragsalian, do we wanna fix this for pressable as we already handled the case for tooltip?

[sakluger]

I can't reproduce this by starting a new group chat on mobile:

@mvtglobally when would this scenario happen in real life?

[chiragsalian]

I'm also unable to reproduce on dev, staging or production.
I don't get the action steps nor why would we need to do that, if we modify code there is a high chance things won't work as expected. If there is a reason to modify the code then the place where the code is modified should address fixing this alignment.

do we wanna fix this for pressable as we already handled the case for tooltip?

@Tushu17, for my understanding whats the benefit on Pressable onPress={() versus Text onPress={()?

[Tushu17]

In a PR earlier we were facing problem when we tried wrapping the text inside pressable or tooltip so you asked us(here) to report it on slack but we have already found a solution and wrapping text inside tooltlip works fine so I don't think we need it.

[melvin-bot]

@sakluger, @mvtglobally Eep! 4 days overdue now. Issues have feelings too...

[chiragsalian]

Ah cool cool, yeah i think when you earlier mentioned it i thought it was a bug on staging/prod. Since a solution was found we don't need this issue and we can close it out, correct?

[sakluger]

Yeah I'm going to close. @mvtglobally could you please reopen if we still need it and let us know what still needs to be fixed? Thanks!

[melvin-bot]

@sakluger Be sure to fill out the Contact List!