[HOLD for payment 2022-03-02] IPAD -Attachment - Extra white line displayed in Preview page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in app
2. Tap on any conversation, click on the + button in the compose box
3. Click on add attachment
4. Upload a PDF file
5. Tap on the PDF preview

Expected Result:

The preview page should not display an extra white line

Actual Result:

Extra white line displayed in Preview page

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS IPAD

Version Number: 1.1.36.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5439323_Ipad_0402-video.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kakajann]

Proposal

This diff will solve this issue

diff --git a/src/components/AttachmentModal.js b/src/components/AttachmentModal.js
index 1fc8d10c5..0d0b80417 100755
--- a/src/components/AttachmentModal.js
+++ b/src/components/AttachmentModal.js
@@ -139,7 +139,7 @@ class AttachmentModal extends PureComponent {
             ? addEncryptedAuthTokenToURL(this.state.sourceURL)
             : this.state.sourceURL;

-        const attachmentViewStyles = this.props.isSmallScreenWidth
+        const attachmentViewStyles = this.props.isSmallScreenWidth || this.props.isMediumScreenWidth
             ? [styles.imageModalImageCenterContainer]
             : [styles.imageModalImageCenterContainer, styles.p5];

Here is the result:

Before	After

[yuwenmemon]

@kakajann looks good to me!

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Current assignee @puneetlath is eligible for the AutoAssignerTriage assigner, not assigning anyone new.

[puneetlath]

Upwork job is here: https://www.upwork.com/jobs/~01a2f3a842d8be6290

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

[rushatgabhane]

🎀👀🎀 C+ reviewed

@puneetlath,
@kakajann's proposal should fix this issue.

[puneetlath]

Yep, I agree. Nice and simple.

@kakajann please let me know when you've applied to the Upwork job.

[MelvinBot]

📣 @kakajann You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[kakajann]

@puneetlath Applied

[kakajann]

I think I made a mistake when I link this issue on PR. What can I do to retrigger the Pullerbear?

[rushatgabhane]

@kakajann you didn't link the issue properly.

Replace those two lines with this -
$ https://github.com/Expensify/App/issues/number

[kakajann]

@rushatgabhane, yeah, fixed it but it doesn't retrigger the Pullerbear I guess. Tried pushing empty commit but didn't help.

[rushatgabhane]

You could close this PR and create a new one

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[puneetlath]

Not overdue. Awaiting production deploy.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove extra white space on attachment modal [iPad] #7716

If no regressions arise, payment will be issued on 2022-03-02. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[puneetlath]

Paid!