[HOLD for payment 2023-05-03] [HOLD for payment 2023-04-26] [$32,000] Allow keyboard shortcuts to work on native devices

[jasperhuangg]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Try to use <Command, K> to access the chat switcher on my tablet.

Expected Result:

The chat switcher should open

The goal is to let native listen and react to hardware keyboard shortcuts similar to how it works in web.

Actual Result:

Keyboard shortcuts doesn't work. It doesn't open.

Workaround:

Nope.

Platform:

Where is this issue occurring?

• iOS
• Android

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[parasharrajat]

@jasperhuangg Don't forget to revert #6881 which hides the shortcut button from the settings page.

[MelvinBot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[mananjadhav]

@jasperhuangg Is there any progress here? If you're fine and like to make it External, I can help with this.

[MelvinBot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @luacmartins (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.1-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow keyboard shortcuts to work on native devices #14767

If no regressions arise, payment will be issued on 2023-04-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow keyboard shortcuts to work on native devices #17708

If no regressions arise, payment will be issued on 2023-05-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[luacmartins]

BZ checklist is not applicable in this case, since this is a new feature.

[azimgd]

@kadiealexander are we good to go?

[kadiealexander]

Yes I believe so! I've sent contracts to @azimgd and @parasharrajat at the new agreed price of $40,000 (discussed here).

[parasharrajat]

@kadiealexander can you please send the offer again?

[parasharrajat]

@kadiealexander Accepted it.

[kadiealexander]

Everyone is paid. @luacmartins I think this issue is too old to have a bugzero regression checklist, do you think it needs a regression test or should I close the issue?

[parasharrajat]

No Regression test is needed on this.