Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS/Android - Black screen is displayed when try to create room #6712

Closed
kbecciv opened this issue Dec 11, 2021 · 4 comments
Closed

IOS/Android - Black screen is displayed when try to create room #6712

kbecciv opened this issue Dec 11, 2021 · 4 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Dec 11, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open App and login with expensify account
  2. Tap on Plus [+] and select "New Room" in the global create menu
  3. Type test_room_name into the room name input and select a workspace. Click "Create Room".
  4. Type test_room_name into the Room Name input.

Expected Result:

Verify that the A room with this name already exists error message displays (in real-time as you finish typing test_room_name).

Actual Result:

The black screen is displayed for IOS. White screen displayed for Android app

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.20-0

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5368381_RPReplay_Final1639187392.mp4

Expensify/Expensify Issue URL:

Issue was found when executing: #6314

Slack conversation: N/A

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Dec 11, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title IOS/Android - Black screen is displayed when try to create room with same name IOS/Android - Black screen is displayed when try to create room Dec 11, 2021
@mountiny
Copy link
Contributor

Gonna take this over @tylerkaraszewski as my fix for other Deploy block should fix this as well, I hope.

The problem is that we have parsing the reportName for basic policy room incorrectly and it ends up being an empty string. Then this line is false and nothing is shown in the View and this throws error on Mobile.

The fix to the parsing should name sure the reportName is wont be false and the blank page should not occur.

@mountiny mountiny added the Reviewing Has a PR in review label Dec 12, 2021
@mountiny
Copy link
Contributor

PR is in a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants