Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message ''A room with this name already exist'' isn't displayed after type the same name for room the Room Name input #6709

Closed
kbecciv opened this issue Dec 11, 2021 · 5 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Dec 11, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click "New Room" in the global create menu
  2. Type test_room_name into the room name input and select a workspace. Click "Create Room".
  3. Type test_room_name into the Room Name input and Click "Create Room".

Expected Result:

Verify that the A room with this name already exists error message displays (in real-time as you finish typing test_room_name).

Actual Result:

Error "the A room with this name already exists" message isn't displays.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

**Version Number:1.1.20-0
**Reproducible in staging?:Yes
**Reproducible in production?:No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Video
Expensify/Expensify Issue URL:
**Issue was found when executing:**#6314
Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Dec 11, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv closed this as completed Dec 11, 2021
@kbecciv kbecciv reopened this Dec 11, 2021
@mountiny mountiny added Weekly KSv2 Improvement Item broken or needs improvement. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 12, 2021
@mountiny
Copy link
Contributor

@TomatoToaster This is a regression from the New Room PR. I do not think this must be a deploy blocker as it does not break anything, but it would be good to investigate. The tester has copied the string name into the text input field, which is different way than what I could see on the videos in the PR where it was typed, so not sure if that could be the reason.

@mountiny mountiny mentioned this issue Dec 12, 2021
5 tasks
@mountiny mountiny added DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 and removed Weekly KSv2 labels Dec 12, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny added the Reviewing Has a PR in review label Dec 12, 2021
@mountiny
Copy link
Contributor

PR up and ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants