Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove div usage in Onfido component #6465

Closed
luacmartins opened this issue Nov 24, 2021 · 1 comment
Closed

Remove div usage in Onfido component #6465

luacmartins opened this issue Nov 24, 2021 · 1 comment
Assignees
Labels

Comments

@luacmartins
Copy link
Contributor

Problem

We have a <div> usage in the Onfido component.

Why this is important?

While divs are ok in Web, they might become a bad example and be copied to native solutions and crash the app, which has already happened a couple times.

Solution

Replace the div usage with a View component.

@luacmartins luacmartins added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Nov 24, 2021
@luacmartins luacmartins self-assigned this Nov 24, 2021
@MelvinBot
Copy link

Triggered auto assignment to @kevinksullivan (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Nov 24, 2021
@luacmartins luacmartins added the Reviewing Has a PR in review label Nov 24, 2021
@botify botify closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants