Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2021-10-28 #6106

Closed
29 tasks done
OSBotify opened this issue Oct 28, 2021 · 9 comments
Closed
29 tasks done

Deploy Checklist: New Expensify 2021-10-28 #6106

OSBotify opened this issue Oct 28, 2021 · 9 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 28, 2021 •
edited by roryabraham
Loading

Release Version: 1.1.11-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads
@roryabraham
Copy link
Contributor

Checking off #4 which was added in error.

@roryabraham roryabraham mentioned this issue Oct 28, 2021
Merged
5 tasks
@roryabraham
Copy link
Contributor

Checking off #6099 which already passed staging QA. See #4977

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 28, 2021
@mvtglobally
Copy link

Starting QA

@isagoico
Copy link

isagoico commented Oct 29, 2021 •
edited by roryabraham
Loading

Regression is finished!
Blockers found this round:

  1. Settings - Blank page opens when user navigates to Profile screen #6110 - fix hasSelfSelectedPronouns boolean fix #6114 being deployed here

We're working on exporting a few more issues (none of them are deploy blockers tho)

Thanks!

@roryabraham
Copy link
Contributor

@isagoico Did you miss this one? #5940

@isagoico
Copy link

isagoico commented Oct 29, 2021 •
edited
Loading

🤦 I missed to add it to the comment above. It mentions No QA so not sure if it will be taken care of internally, wanted to confirm before checking it off.

@Jag96
Copy link
Contributor

Jag96 commented Oct 29, 2021

I just ran through the tests for #5940 and checked it off!

@roryabraham
Copy link
Contributor

Verified #6114 on staging in 1.1.11.1. Checking it off! 🎉

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Jag96 @applausebot @mvtglobally @isagoico @roryabraham @OSBotify