[HOLD for payment 2024-09-12][$250] Can't edit messages by pressing UP ARROW

[iwiznia]

Previous issue that should've fixed this #46391

Steps

1. Open a chat
2. Send a message
3. Press UP ARROW
4. Edit of message is not started when it should

This is happening on web in staging but not in production

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831333353313013695
• Upwork Job ID: 1831333353313013695
• Last Price Increase: 2024-09-04
• Automatic offers:
• ishpaul777 | Reviewer | 103816825

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Julesssss]

@iwiznia should this single platform shortcut really block the deploy?

[iwiznia]

🤷 maybe not, feel free to remove the blocker if you disagree

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831333353313013695

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[stitesExpensify]

cc @puneetlath @fedirjh @bernhardoj

[bernhardoj]

It's not caused by #47133 since the PR was deployed 3 weeks ago. Looks like the selectionStart here is always undefined.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 489 to 490 in a956db6

	'selectionStart' in textInputRef.current &&
	textInputRef.current?.selectionStart === 0 &&

[Julesssss]

maybe not, feel free to remove the blocker if you disagree

I'll leave it up to Rory, maybe it's resolved before the decision has to be made

[iwiznia]

BTW this is in our regression testing and in fact applause had reported it a few minutes before me here #48548

[puneetlath]

This seems worthy of a deploy blocker to me. It's on our primary platform.

[fedirjh]

This is a regression from :

• Fix cursor moving before the emoji when typing  #48234

which has bumped the version of react-native-live-markdown to include changes from this PR

• Fix cursor selection event on the web react-native-live-markdown#459

which in return has deprecated the selectionStart in flavour of selection prop.

So we should update this line

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 489 to 490 in a956db6

	'selectionStart' in textInputRef.current &&
	textInputRef.current?.selectionStart === 0 &&

Actually, we can remove this check and use the selection state directly :

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 299 in a956db6

const [selection, setSelection] = useState<TextSelection>(() => ({start: value.length, end: value.length, positionX: 0, positionY: 0}));

Code :

-   'selectionStart' in textInputRef.current && 
-   textInputRef.current?.selectionStart === 0 && 
+    selection.start === 0 && 

Let me know if that makes sense and I can raise a PR.

[ishpaul777]

@fedirjh's Solution makes sense and works well

🎀 👀 🎀 C+ reviewed

Screen.Recording.2024-09-04.at.10.06.58.PM.mov

[melvin-bot]

Current assignee @stitesExpensify is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[Skalakid]

I checked the issue and I like @fedirjh solution. However, to be extra safe I would change the added condition to
selection.start <= 0 since selection.start can be equal to -1 just after reloading the page:

Screen.Recording.2024-09-04.at.18.48.10.mov

So if you want to enable users to edit messages in this case, @fedirjh please include this code in your PR ;)

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[ishpaul777]

This is fixed and CPd #48585 (comment), we can remove Deployblocker label

[johncschuster]

Issuing payment tomorrow assuming no regressions 👍

[johncschuster]

Payment Summary:

Contributor: @fedirjh owed $250 via NewDot
Contributor+: @ishpaul777 paid $250 via Upwork - PAID! 🎉

[johncschuster]

I've asked a clarifying question around the payment being made in the linked issue (comment, here). I'll monitor that and update this issue once we've come to the bottom of it.

[johncschuster]

Confirmed the linked issue is not related and the payment should not be penalized.

[johncschuster]

@fedirjh, please go ahead and request payment on ND 👍