Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign up - no magic code is sent/account appears as deleted if someone starts a chat before account is created #47979

Closed
6 tasks done
CyberAndrii opened this issue Aug 25, 2024 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@CyberAndrii
Copy link
Contributor

CyberAndrii commented Aug 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.24-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: @CyberAndrii

Action Performed:

  1. User A: Go to staging.new.expensify.com
  2. User A: Create a new account or log into an existing one
  3. User A: Click "+" in the LHN then "Start chat"
  4. User A: Enter an email of a non-existing user and open the chat
  5. User B: Go to staging.new.expensify.com
  6. User B: Enter the email from step 4 and click "Continue"

Expected Result:

User B should not be asked to enter the magic code

Actual Result:

User B is asked to enter the magic code, which is never received, even after requesting it again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

no.magic.code.is.sent.webm

When entering email of User B and clicking the "Continue" button without clicking the "Join" button:

account.is.deleted.webm
The account you are trying to use is deleted.

View all open jobs on GitHub

@CyberAndrii CyberAndrii added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Aug 25, 2024
@melvin-bot melvin-bot bot closed this as completed Aug 25, 2024
Copy link

melvin-bot bot commented Aug 25, 2024

📣 @CyberAndrii! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

Copy link

melvin-bot bot commented Aug 25, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@CyberAndrii
Copy link
Contributor Author

CyberAndrii commented Aug 25, 2024

Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!

@trjExpensify If only it was possible to join the Slack... See #45804.

Please reopen or let the QA team know. Thank you

@trjExpensify
Copy link
Contributor

@m-natarajan can you take a look at this and create the bug if reproducible? Thanks!

@m-natarajan
Copy link

@trjExpensify User B asked to enter the magic code and I received it.

Recording.490.mp4

@trjExpensify
Copy link
Contributor

Cool yeah, so that seems expected then.

  1. User B was invited to Expensify
  2. They didn't click the link in the email which would have provided an unvalidated first session if they did
  3. They navigated to new.expensify.com natively and entered their email address
  4. They were prompted for a magic code to sign-in
  5. They received the magic code on email, entered it, and validated the account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants