Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Desktop - Unable to log out as user remains logged in after logging out #47088

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 8, 2024 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify desktop app
  2. Log out if logged in
  3. Log in to New Expensify on Chrome
  4. After login, refresh the page on Chrome
  5. Click Open New Expensify
  6. On desktop app, sign out

Expected Result:

App will redirect to login screen after signing out

Actual Result:

App is unable to sign out. User remains signed in after signing out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6565606_1723121931532.20240808_205625.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01263806ac93543c43
  • Upwork Job ID: 1821608786482827857
  • Last Price Increase: 2024-08-08
Issue OwnerCurrent Issue Owner: @ishpaul777
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@neil-marcellini
Copy link
Contributor

Looking now

@neil-marcellini neil-marcellini added the External Added to denote the issue can be worked on by a contributor label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01263806ac93543c43

@melvin-bot melvin-bot bot changed the title Desktop - Unable to log out as user remains logged in after logging out [$250] Desktop - Unable to log out as user remains logged in after logging out Aug 8, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

@neil-marcellini
Copy link
Contributor

After log out there's a call to sign in with the short lived auth token. I'm guessing this has something to do with the transition flow.
image

@neil-marcellini neil-marcellini removed the DeployBlocker Indicates it should block deploying the API label Aug 8, 2024
@neil-marcellini
Copy link
Contributor

Actually, there's a chance this could be backend so re-applying the label until I learn more.

@neil-marcellini neil-marcellini added the DeployBlocker Indicates it should block deploying the API label Aug 8, 2024
@ishpaul777
Copy link
Contributor

I am not able to reproduce in Dev Desktop app, Have you been able to reproduce in dev @neil-marcellini ?

@neil-marcellini
Copy link
Contributor

I can't reproduce on dev either 😢. Maybe it's fixed? Hard to say. I'm thinking we'll have to compare the console and network logs to see if we can spot a difference between staging and production, or dev.

@ishpaul777
Copy link
Contributor

ishpaul777 commented Aug 8, 2024

This is fixed on staging, by #47099 i guess, @neil-marcellini can you please retest and confirm?

@neil-marcellini
Copy link
Contributor

Ah yep that did it, nice! All done.

desktop-signout.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants