Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2P Distance] - Group chat avatar changes after splitting distance expense with existing users #47020

Closed
6 tasks done
m-natarajan opened this issue Aug 8, 2024 · 15 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #42302
Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: New Feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Split expense > Distance.
  3. Enter waypoints > Next.
  4. Select two existing users.
  5. Split the distance expense.

Expected Result:

The group chat style will remain the same (avatar and report details RHP name).

Actual Result:

The group chat style changes after splitting the distance expense. Avatar changes to stacked avatars style and report details RHP name is "chat report".## Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6565068_1723072191475.20240808_070525.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-split

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
@mountiny
Copy link
Contributor

mountiny commented Aug 8, 2024

Does not feel like a deploy blocker as this is a new feature and UX issue.

@neil-marcellini do you want to take this one over as its related to the distance split project. It looks like as if we are creating the old group chat style in the backend instead of the new GroupDM

@Christinadobrzyn Christinadobrzyn added the NewFeature Something to build that is a new item. label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Current assignee @Christinadobrzyn is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@shawnborton
Copy link
Contributor

@marcaaron can you please have a look at this, as I think it relates to the group chat stuff you had worked on? Thanks!

@marcaaron
Copy link
Contributor

It looks like as if we are creating the old group chat style in the backend instead of the new GroupDM

We should definitely not be doing that.

Taking a quick look but seems like maybe this issue should be labeled Internal and assigned to @neil-marcellini.

@neil-marcellini neil-marcellini added the Internal Requires API changes or must be handled by Expensify staff label Aug 13, 2024
@neil-marcellini neil-marcellini changed the title Distance - Group chat avatar changes after splitting distance expense with existing users [P2P Distance] - Group chat avatar changes after splitting distance expense with existing users Aug 13, 2024
@Christinadobrzyn
Copy link
Contributor

Just checking in on this - @neil-marcellini do you have an update? thank you!

@neil-marcellini
Copy link
Contributor

I got a fix up for review!

@neil-marcellini neil-marcellini added the Reviewing Has a PR in review label Aug 15, 2024
@neil-marcellini
Copy link
Contributor

Head's up, I'll be working 50% for the rest of this week and next 🌲

@Christinadobrzyn
Copy link
Contributor

PR in staging - getting close!

@neil-marcellini
Copy link
Contributor

Deployed to prod, all done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants