Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-19] [Fullstory] Initializing the Onyx object to identify the user when they have an infinite session on New Dot #46677

Closed
anmurali opened this issue Aug 1, 2024 · 3 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@anmurali
Copy link

anmurali commented Aug 1, 2024

Problem:
Initializing the Onyx object on SignInWithShortLivedAuthToken will make it so a user on Classic with an infinite session, on redirect to New Dot will now be identified in FS. But if they were already on New Dot, and had an infinite session, we will not identify them till they explicitly login next.

Solution:
Initialize this object on OpenApp/Reopen App as well.

Note: While we do this, can we also make it so the Onyx object includes the tryNewDot.classicRedirect.dismissed
If that is true - send true, if false then send false
If that NVP does not exist, send empty

@danieldoglas danieldoglas added the Daily KSv2 label Aug 5, 2024
@trjExpensify trjExpensify changed the title Initializing the Onyx object to identify the user when they have an infinite session on New Dot [Fullstory] Initializing the Onyx object to identify the user when they have an infinite session on New Dot Aug 5, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Aug 6, 2024
@melvin-bot melvin-bot bot changed the title [Fullstory] Initializing the Onyx object to identify the user when they have an infinite session on New Dot [HOLD for payment 2024-08-19] [Fullstory] Initializing the Onyx object to identify the user when they have an infinite session on New Dot Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-19. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 18, 2024
@danieldoglas
Copy link
Contributor

This is done, there's no payment to be made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

2 participants