Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #46369

Closed
github-actions bot opened this issue Jul 27, 2024 · 6 comments
Assignees

Comments

@github-actions
Copy link
Contributor

🚨 Failure Summary 🚨:

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named e2ePerformanceTests / Run E2E tests in AWS device farm.
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

@rafecolton
Copy link
Member

@marcaaron can you look at this one with me? I'm not really sure what to do here. The changes in performance it's showing don't look at all related to your change

Screenshot 2024-07-27 at 2 46 33 PM

We also failed to notify in Slack, I think because the room title changed from #newdot-performance to #newdot-quality. For that one, maybe we should change to the room ID if that's possible?

I'm not sure if this should actually be a deploy blocker, so I'm going to change this to Daily for now. LMK!

@marcaaron
Copy link
Contributor

I'm not too sure on either account. Agree that the failure is unrelated - it's a performance test so there are probably some circumstances that can cause false positives. Looks like the PR did not get deployed to staging though so we can try to re-run the job.

@marcaaron
Copy link
Contributor

Tried running them again but they failed. I would guess it's some problem with AWS or that something else caused a regression (other people are reporting the same thing)

@rafecolton
Copy link
Member

So we can probably close this and remove DeployBlockerCash from the PR? Does having that label on the PR even do anything?

@marcaaron
Copy link
Contributor

That label is applied to issues. QA applies it while doing staging regression and PR testing.

Not sure I've seen it applied to a PR before. But perhaps someone chose to add this as a preventative measure e.g. after the PR moves to staging we could possibly deploy without resolving the problem and we want to avoid that?

Tbh I'm not well versed in the e2e tests or these "Investigate workflow" situations so your guess is as good as mine.

@rafecolton
Copy link
Member

The GH action is what added it to the PR. @roryabraham do you know if this was intentional? It seems like a bug. Regardless, it seems we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants