Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVP] [$250] Free trial of workspace mentioned in welcome message when user have no workspace #46338

Closed
2 of 6 tasks
m-natarajan opened this issue Jul 27, 2024 · 12 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722036482639849

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new account and select Track in onboarding
  3. Click the global + > Track
  4. Choose the Submit to someone actionable mention

Expected Result:

No mention about free trial workspace in concierge message

Actual Result:

Mentioned about workspace in the message even if the user not created a workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Recording.388.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01aa51c694d41de340
  • Upwork Job ID: 1818323017692441626
  • Last Price Increase: 2024-08-06
Issue OwnerCurrent Issue Owner: @situchan
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 27, 2024
Copy link

melvin-bot bot commented Jul 27, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
@abekkala abekkala added the External Added to denote the issue can be worked on by a contributor label Jul 30, 2024
@melvin-bot melvin-bot bot changed the title Free trial of workspace mentioned in welcome message when user have no workspace [$250] Free trial of workspace mentioned in welcome message when user have no workspace Jul 30, 2024
Copy link

melvin-bot bot commented Jul 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01aa51c694d41de340

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 30, 2024
Copy link

melvin-bot bot commented Jul 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@melvin-bot melvin-bot bot removed the Overdue label Jul 30, 2024
@situchan
Copy link
Contributor

Awaiting proposals

@VincentCorleone
Copy link

I think it is a backend issue

Copy link

melvin-bot bot commented Aug 5, 2024

@abekkala, @situchan Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Aug 5, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@trjExpensify trjExpensify changed the title [$250] Free trial of workspace mentioned in welcome message when user have no workspace [CVP] [$250] Free trial of workspace mentioned in welcome message when user have no workspace Aug 6, 2024
@trjExpensify
Copy link
Contributor

I can only repro this in the Track > Submit someone flow:

2024-08-06_20-55-47.mp4

Looks like we call OpenWorkspace in the ConvertedTrackedExpenseToRequest flow (logs for that API call), and I'm not sure why @thienlnam?

OpenWorkspace Logs

[104.28.159.59->/api.php] Malformed REQUEST: 'policyID' = '-1', ignoring (should match '[A-F0-9]+').

CC: @chiragsalian for visibility on free trial stuff.

@chiragsalian
Copy link
Contributor

This looks like an internal bug. Looks like jack's already got a PR for this.

@chiragsalian chiragsalian added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Aug 7, 2024
@trjExpensify trjExpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 7, 2024
@trjExpensify trjExpensify assigned trjExpensify and unassigned situchan and abekkala Aug 7, 2024
@trjExpensify
Copy link
Contributor

Auth and Web PRs for this now merged, awaiting deploys.

@danielrvidal
Copy link
Contributor

Doe this still need to be open? It looks like they both merged above.

@thienlnam
Copy link
Contributor

Yup, looks resolved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

8 participants