Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Profile - Selected pronoun is not visible in the "Preferred Pronouns" field #4628

Closed
kavimuru opened this issue Aug 12, 2021 · 16 comments · Fixed by #4641
Closed
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Aug 12, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with account you don't have last and first name setsup up.
  3. Go to Settings - Profile
  4. On Preferred Pronouns dropdown field select any.

Expected Result:

I expected to see the selected option in my profile.

Actual Result:

Selected the option in the "Preferred Pronouns" isn't visible in the field.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.0.85-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5190778_Screen_Recording_20210812-135805_Expensifycash.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Aug 12, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kakajann
Copy link
Contributor

Hi, I just investigated and found this

Apperantly, this is a react-native-picker-selects bug. And passing color style for Picker solves the issue.

I can open a PR

@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Aug 13, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@roryabraham
Copy link
Contributor

Great find @kakajann! Feel free to submit a PR, and we'll get an Upwork job created for you ASAP.

@jliexpensify
Copy link
Contributor

Posted to Upworks - https://www.upwork.com/ab/applicants/1425989377062014976/job-details

@kakajann - feel free to apply there, and I'll hire you.

@kakajann
Copy link
Contributor

@jliexpensify Applied and opened a pr

@Beamanator
Copy link
Contributor

@kakajann @roryabraham would you say this issue was caused by @kakajann 's PR #3414? It looks related since that PR created the expensiPicker style, which is all that was changed in the PR that fixed this issue

@roryabraham
Copy link
Contributor

roryabraham commented Aug 13, 2021

Reopening pending payment

@roryabraham roryabraham reopened this Aug 13, 2021
@francoisl francoisl added Reviewing Has a PR in review and removed Daily KSv2 labels Aug 13, 2021
@roryabraham
Copy link
Contributor

@kakajann @roryabraham would you say this issue was caused by @kakajann 's PR #3414? It looks related since that PR created the expensiPicker style, which is all that was changed in the PR that fixed this issue

@Beamanator that's a good point

@roryabraham roryabraham added Weekly KSv2 and removed Hourly KSv2 labels Aug 13, 2021
@roryabraham
Copy link
Contributor

@kavimuru This should be fixed in v1.0.85-5+

@isagoico
Copy link

#4554 (comment) retest was a pass, closing.

@jliexpensify
Copy link
Contributor

@roryabraham and @Beamanator - apologies, I'm just a little confused: should I be paying @kakajann for this job? The previous comments indicate not, correct?

@roryabraham
Copy link
Contributor

roryabraham commented Aug 20, 2021

Okay, so reviewing what happened here:

  1. @kakajann submitted PR: Create custom TextInput #3414, which caused a regression.
  2. @kakajann quickly volunteered to fix the regression.
  3. I failed to notice that the regression was caused by Create custom TextInput #3414, and agreed to create a new Upwork job and hire @kakajann to fix the regression. This was a mistake on my part.

However, since #3414 caused the regression, it was already @kakajann's responsibility to fix the regression. So a second job should have never been created. Therefore, I don't think we should pay out the second job.

This is a situation I have personally never been in with a contributor before, so as far as I know we don't have a precedent se here, but it seems fair to me. @kakajann please let us know if you disagree.

@kakajann
Copy link
Contributor

I don't mind to end the contract from upwork. I wasn't aware this issue is my regression.

@jliexpensify
Copy link
Contributor

Thanks for your understanding and for accepting this outcome @kakajann . Contract has been cancelled in Upwork.

Hope to work with you again soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants