Search - Hold option is present for expense that is still scanning on Search page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.11-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit a scan expense
4. Go to transaction thread
5. Click on the report header
6. Note that Hold option is not present when the receipt is still scanning
7. Go to Search
8. Select the scanning expense
9. Click on the dropdown

Expected Result:

Hold option will not be present for expense that is still scanning

Actual Result:

Hold option is present for expense that is still scanning on Search page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6550930_1721765534390.bandicam_2024-07-24_04-07-02-973.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[stitesExpensify]

@luacmartins looks like you have been working on this feature. Would you mind taking over this issue?

[luacmartins]

Sure I can work on this

[luacmartins]

I don't think this is a blocker. Worst case the request to Hold will fail and users might be slightly confused. Next, it seems like we have a bunch of conditions in App that are not enforced by the API. I think we should enforce these in the API as well so I'll work on a PR to add this conditions to Auth. cc @robertjchen

[stitesExpensify]

Makes sense to me. Thanks!

[luacmartins]

PR in review

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

this is done!