Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace Feeds] Expensify Card - Expensify Card page reopens when clicking Back from workspace editor #46045

Closed
4 of 6 tasks
lanitochka17 opened this issue Jul 23, 2024 · 16 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to Workspace settings > Expensify Card
  3. Click Issue card
  4. Click back button to return to Expensify Card main page
  5. Click back button to return to workspace editor
  6. Click back button again

Expected Result:

App will return to workspace list

Actual Result:

App returns to Expensify Card main page again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6550549_1721742754391.ScreenRecording_07-23-2024_18-58-21_1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 23, 2024
Copy link

melvin-bot bot commented Jul 23, 2024

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 2

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jul 23, 2024
@mountiny mountiny assigned mountiny and allgandalf and unassigned blimpich Jul 23, 2024
@mountiny
Copy link
Contributor

This is not a blocker as this feature is behind beta

@mountiny mountiny changed the title Expensify Card - Expensify Card page reopens when clicking Back from workspace editor [Workspace Feeds] Expensify Card - Expensify Card page reopens when clicking Back from workspace editor Jul 23, 2024
@koko57
Copy link
Contributor

koko57 commented Jul 23, 2024

I can take this one

@koko57
Copy link
Contributor

koko57 commented Jul 24, 2024

@mountiny
Copy link
Contributor

Thanks

@lanitochka17
Copy link
Author

Issue is still reproducible on the 9.0.11-2

ScreenRecording_07-24-2024.22-11-23_1.1.MP4

@lanitochka17 lanitochka17 reopened this Jul 24, 2024
@mountiny
Copy link
Contributor

cc @koko57

@koko57
Copy link
Contributor

koko57 commented Jul 26, 2024

@lanitochka17 can you please retest on production version 9.0.11-5 or 9.012-0? The line I mentioned earlier fixes the issue for sure, it was deployed to staging in version 9.0.11-2, to production 9.0.11-5 or 9.0.12-0. So if you were retesting production version of 9.0.11-2 the change wasn't there.

I cannot reproduce it locally in v 9.0.13-0 Develop
https://github.com/user-attachments/assets/aa649f6c-dc01-46e4-9e2a-6c78cc65671d

@allgandalf
Copy link
Contributor

bump @lanitochka17 for a retest

@allgandalf
Copy link
Contributor

same as ^

@lanitochka17
Copy link
Author

Issue is not reproducible

ScreenRecording_08-01-2024.01-07-59_1.MP4

@allgandalf
Copy link
Contributor

Lets close this one @mountiny

@allgandalf allgandalf removed their assignment Aug 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 5, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

@mountiny Huh... This is 4 days overdue. Who can take care of this?

@mountiny
Copy link
Contributor

mountiny commented Aug 7, 2024

nice, thanks

@mountiny mountiny closed this as completed Aug 7, 2024
@melvin-bot melvin-bot bot removed Overdue labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants