[$250] [HOLD for payment 2024-08-19] [Search v2.1] [App] Create Currency filter

[luacmartins]

Implement this section of the design doc for the Currency filter only!

cc @adamgrzybowski @Kicu @WojtekBoman @Guccio163

Issue Owner

Current Issue Owner: @garrettmknight / @sonialiap

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01779f92052196d8af
• Upwork Job ID: 1826031089726034388
• Last Price Increase: 2024-08-20
• Automatic offers:
• ikevin127 | Contributor | 103610903

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[WojtekBoman]

Hi! I'd like to work on this issue :)

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[garrettmknight]

@sonialiap will pick this back up when I'm back from OOO, thanks for your help in the meantime!

[sonialiap]

@WojtekBoman thanks for volunteering! How's the implementation going?

[WojtekBoman]

@sonialiap I was focused on fixing all the issues in the Create Search Results page issue , now I'm starting to work on that :)

[garrettmknight]

@sonialiap just a note that I'll pick this one back up!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Search v2] [App] Create Currency filter  #46566

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@WojtekBoman] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@garrettmknight / @sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[garrettmknight]

@luacmartins I didn't notice any currency specific filter test in the manual tests for this project. Did I miss them or should we add a regression test here?

[luacmartins]

This feature is still WIP, so we'll add them as part of the project wrap up.

[garrettmknight]

Cool - closing then!

[ikevin127]

@garrettmknight I just checked Upwork and looks like I wasn't paid for reviewing the PR for this issue.

[garrettmknight]

Let's fix that.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01779f92052196d8af

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[garrettmknight]

Accept the offer and I'll pay!

[ikevin127]

@garrettmknight Offer accepted ✅

[garrettmknight]

Sweet - all paid up!