Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-05] [$250] [HybridApp] 'Update App' page redirects users to NewDot standalone #45911

Closed
Julesssss opened this issue Jul 22, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Jul 22, 2024

cc @trjExpensify @AndrewGable

Problem

Hybrid users can't access the app when the version doesn't match the current min-version. Users with the redirection NVP set get stuck on each app open. The 'update' button takes them to the NewDot standalone app which isn't helpful.

Screenshot_20240722_140758

Solution

Update the URL to OldDot app listing before Hybrid is shipped.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fd6e839e5481e762
  • Upwork Job ID: 1817838538974475497
  • Last Price Increase: 2024-07-29
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @twisterdotcom
@Julesssss Julesssss added Engineering Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Jul 22, 2024
@Julesssss Julesssss self-assigned this Jul 22, 2024
@trjExpensify trjExpensify changed the title [Hybrid] 'Update App' page redirects users to NewDot standalone [HybridApp] 'Update App' page redirects users to NewDot standalone Jul 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 24, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Jul 25, 2024
@hungvu193
Copy link
Contributor

@Julesssss Since I reviewed #46194, can you please assign me to this issue? TIA 😄

@staszekscp
Copy link
Contributor

I think this can be closed 😄

@Julesssss Julesssss added the External Added to denote the issue can be worked on by a contributor label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01fd6e839e5481e762

@melvin-bot melvin-bot bot changed the title [HybridApp] 'Update App' page redirects users to NewDot standalone [$250] [HybridApp] 'Update App' page redirects users to NewDot standalone Jul 29, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Current assignee @hungvu193 is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 29, 2024
@Julesssss Julesssss added Weekly KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 29, 2024
@Julesssss
Copy link
Contributor Author

Assigning BZ for payment. @twisterdotcom this is complete, can you just pay out a PR review for @hungvu193 please

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 29, 2024
@melvin-bot melvin-bot bot changed the title [$250] [HybridApp] 'Update App' page redirects users to NewDot standalone [HOLD for payment 2024-08-05] [$250] [HybridApp] 'Update App' page redirects users to NewDot standalone Jul 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jul 29, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
  • [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@hungvu193] Determine if we should create a regression test for this bug.
  • [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@twisterdotcom
Copy link
Contributor

Payment Summary:

@hungvu193
Copy link
Contributor

Requested on ND

@JmillsExpensify
Copy link

$250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

5 participants