Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories - GL code comes back after clearing the field and reopening the category editor #45442

Closed
6 tasks done
m-natarajan opened this issue Jul 16, 2024 · 9 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


issue found when validating #43155
Version Number: 9.0.7-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

  • Workspace is under Control plan.
  1. Go to staging.new.expensify.com
  2. Go to Control workspace settings > Categories.
  3. Click on any category.
  4. Click GL code.
  5. Enter a GL code and save.
  6. Click GL code again.
  7. Clear the GL code and save.
  8. Close the RHP.
  9. Click on the same category again.

Expected Result:

The GL code field will remain cleared.

Actual Result:

The GL code field is populated with old value and is not cleared.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6543254_1721080709801.20240716_055555.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@dylanexpensify
Copy link
Contributor

cc @rushatgabhane @Gonals

@Gonals Gonals removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 16, 2024
@Gonals Gonals assigned Gonals and unassigned hayata-suenaga Jul 16, 2024
@Gonals Gonals added the Improvement Item broken or needs improvement. label Jul 16, 2024
@Gonals
Copy link
Contributor

Gonals commented Jul 16, 2024

Not a blocker, as it doesn't break existing functionality. This is getting fixed here

@Gonals Gonals added Reviewing Has a PR in review Daily KSv2 and removed Hourly KSv2 labels Jul 16, 2024
@dylanexpensify
Copy link
Contributor

Perfecto!

@dylanexpensify
Copy link
Contributor

fix ongoing

@dylanexpensify
Copy link
Contributor

@Gonals is this still occurring?

@Gonals
Copy link
Contributor

Gonals commented Jul 23, 2024

Nope!

@Gonals Gonals closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants