Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-24] Desktop - Unable to login Google/ Apple button #45284

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 11, 2024 · 13 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4708479
Email or phone of affected tester (no customers): rybkina@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch App
  2. Tap on Google/ Apple button on sign in page
  3. Tap on Allow on popup on web " Do you want to allow this website to open “New Expensify”?

Expected Result:

Desktop App should be open as login user via Google/ Apple

Actual Result:

Desktop App opens on sign in page but not login

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538976_1720705331685.google.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 11, 2024
Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Julesssss
Copy link
Contributor

Quite possibly related to our other redirect blockers. Discussing in Slack.

Copy link

melvin-bot bot commented Jul 11, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins
Copy link
Contributor

Fixed here

@luacmartins luacmartins added the Reviewing Has a PR in review label Jul 11, 2024
@kavimuru
Copy link

kavimuru commented Jul 12, 2024

Issue is not fixed.

20240712_203845.1.mp4

@Julesssss
Copy link
Contributor

Issue is not fixed.

Hey @kavimuru, we think this was fixed. Is the desktop version up to date?

@kavimuru
Copy link

@Julesssss Build is not updated to the latest.

@luacmartins
Copy link
Contributor

@kavimuru Can we test on the latest build please?

@kavimuru
Copy link

Bug is fixed

fixed.2.mp4

@Julesssss
Copy link
Contributor

Closing as no longer reproducible ❤️

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Jul 15, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot changed the title Desktop - Unable to login Google/ Apple button [HOLD for payment 2024-07-24] Desktop - Unable to login Google/ Apple button Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants