Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-14] [Troubleshooting] Make it possible to export network queue #45275

Closed
puneetlath opened this issue Jul 11, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Jul 11, 2024

Similar to how we make it possible to export Onyx state in the Troubleshooting section, let's make it possible to export the network queue. This will help us in scenarios where we need to see what is happening with the network queue in order to be able to troubleshoot an issue.

Issue OwnerCurrent Issue Owner: @puneetlath
@puneetlath puneetlath added Daily KSv2 NewFeature Something to build that is a new item. Engineering and removed Engineering labels Jul 11, 2024
Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @greg-schroeder (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 11, 2024
@muttmuure
Copy link
Contributor

@adhorodyski @hurali97 could you comment on this one and we'll assign you?

@hurali97
Copy link
Contributor

Hey @puneetlath 👋

I agree that we should be able to export the network queue but let's say, the user is experiencing an issue and we ask him to export the network queue using this new feature and when he does it and shares with us, the network queue is empty, as we know that the queue gets empty over time. In such a case, this feature won't be of helpful.

My proposal is to allow exporting network queue but also allow exporting the network requests and responses. This will come in handy especially on Android and iOS, where we lack the remote debugging. In some cases, it might be useful to analyse the responses from the network. Though, there are some constraints like:

  • There's auth token and user specific details, which we will have to hide
  • The record for keeping the network response will grow over time, so the idea is to not persist this record at all
    • Which means that we will keep this in memory and as soon as the user closes the app, this will be reset and rightly so because we will be only interested in the latest network responses.
    • Also, for in memory record, we can set a limit to how much we want to save because we don't want to bloat the memory.

Let me know what you think of this 👍

@puneetlath
Copy link
Contributor Author

That sounds good to me. But mind posting that in the #newdot-quality room for some more eyes first?

@puneetlath
Copy link
Contributor Author

It's being actively worked on and is getting close.

@melvin-bot melvin-bot bot removed the Overdue label Jul 24, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jul 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 7, 2024
@melvin-bot melvin-bot bot changed the title [Troubleshooting] Make it possible to export network queue [HOLD for payment 2024-08-14] [Troubleshooting] Make it possible to export network queue Aug 7, 2024
Copy link

melvin-bot bot commented Aug 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 7, 2024
Copy link

melvin-bot bot commented Aug 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

  • @hurali97 does not require payment (Contractor)

Copy link

melvin-bot bot commented Aug 7, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hurali97] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 14, 2024
Copy link

melvin-bot bot commented Aug 14, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@puneetlath
Copy link
Contributor Author

Looks like @allroundexperts reviewed this one so needs compensation.

Payment summary:

Thanks y'all!

@JmillsExpensify
Copy link

$250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

6 participants