Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expensify Card - Toggle is auto-disabled after being enabled and disabled once #45274

Closed
1 of 6 tasks
kavimuru opened this issue Jul 11, 2024 · 8 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-1
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-internal team
Slack conversation:

Action Performed:

  1. Navigate to https://staging.new.expensify.com/

  2. Log in with a new expensifail account

  3. Create a workspace

  4. Navigate to Workspace settings > More features

  5. Enable Expensify Card

  6. Navigate to the Expensify card menu

  7. Navigate back to Workspace settings > More features

  8. Disable the Expensify card

  9. Navigate to the Expensify card menu

  10. Navigate again back to More features

  11. Enable the Expensify card

  12. Navigate away from More Features

  13. Navigate back to More Features and check the Expensify Card toggle

Expected Result:

The Expensify Card toggle remains enabled

Actual Result:

The Expensify Card toggle is auto-disabled

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6538932_1720701907190.2024-07-11_15_38_16.mp4

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 11, 2024
Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kavimuru
Copy link
Author

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@iwiznia
Copy link
Contributor

iwiznia commented Jul 11, 2024

@MariaHCD this seems to come from your PR https://github.com/Expensify/Web-Expensify/pull/42651

Do you want to take a look at why this is happening or shall I revert the PR to resolve the blocker?

@Julesssss
Copy link
Contributor

Demoting it as an app blocker as this is a new and WIP feature.

@Julesssss Julesssss added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 11, 2024
@MariaHCD
Copy link
Contributor

Taking over. Like Jules said, it's a WIP feature so doesn't need to block any deploys

@MariaHCD MariaHCD assigned MariaHCD and unassigned iwiznia Jul 12, 2024
@MariaHCD MariaHCD removed the DeployBlocker Indicates it should block deploying the API label Jul 12, 2024
@MariaHCD
Copy link
Contributor

This is likely related to: https://github.com/Expensify/Expensify/issues/412040

We can retest once we have the fix deployed: https://github.com/Expensify/Auth/pull/11580

@MariaHCD MariaHCD added the Reviewing Has a PR in review label Jul 12, 2024
@nkuoch nkuoch closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants