[HOLD for payment 2024-08-01] Accounting - Non-reimbursable and Reimbursable expense options don't get auto focused

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #44921

Action Performed:

Pre-requisite

• Collect workspace with accounting enabled.
• NetSuite beta enabled for the user. (Use expensifail account)
• Setup NetSuite in OldDot.

1. Open the app with the pre-setup workspace.
2. Go to Accounting
3. Tap on the Advanced button.
4. Tap on Non-reimbursable expense option (Enable Custom form ID to access this field)
5. Tap on Reimbursable expense option

Expected Result:

The input field gets auto focused

Actual Result:

The input field does not get auto focused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538061_1720627002225.Screen_Recording_20240710_185320_Chrome.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting - Non-reimbursable and Reimbursable expense options don't get auto focused

What is the root cause of that problem?

NetSuitCustomFormIDPage is missing logic to autofocus the TextInput here

What changes do you think we should make in order to solve the problem?

We will use useAutoFocusInput to configure autofocus on NetSuitCustomFormIDPage here:

App/src/pages/workspace/accounting/netsuite/advanced/NetSuiteCustomFormIDPage.tsx

Lines 83 to 92 in 98932a2

	<InputWrapper
	InputComponent={TextInput}
	inputID={params.expenseType}
	label={translate(`workspace.netsuite.advancedConfig.${isReimbursable ? 'customFormIDReimbursable' : 'customFormIDNonReimbursable'}`)}
	aria-label={translate(`workspace.netsuite.advancedConfig.${isReimbursable ? 'customFormIDReimbursable' : 'customFormIDNonReimbursable'}`)}
	role={CONST.ROLE.PRESENTATION}
	spellCheck={false}
	inputMode={CONST.INPUT_MODE.NUMERIC}
	defaultValue={config?.customFormIDOptions?.[customFormIDKey]?.[CONST.NETSUITE_MAP_EXPORT_DESTINATION[exportDestination]]}
	/>

import useAutoFocusInput from '@hooks/useAutoFocusInput';

const {inputCallbackRef} = useAutoFocusInput();

<InputWrapper
    InputComponent={TextInput}
    ref={inputCallbackRef}
    ....
/>

Alternatively

We may use useFocusEffect() to focus the TextInput.

[stitesExpensify]

Posted here, I think that this is a direct result of this PR #44921

[mananjadhav]

Yes. @shubham1206agra and I will take care of this. You can assign this to us. Also this is behind beta so not a deploy blocker.

cc - @yuwenmemon

[stitesExpensify]

Any update here?

[mananjadhav]

I'll take care of this.

[mananjadhav]

The PR is up and I've also added the fix to the Token Input page.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [#Wave-Control: Add NetSuite] Added auto focus for all NetSuite forms #45507

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @shubham1206agra requires payment (Needs manual offer from BZ)

[mananjadhav]

We can close this one out. The payout will be done centrally.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mananjadhav owed $250 via NewDot
• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct