-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-19] Asking for company name and URL on the first invoice being sent #45174
Comments
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue. |
Updates:
TODOs:
The updates can be found in a Draft PR |
@madmax330 The Draft PR is ready to be opened for review. I just want to confirm a couple of things with you:
Let me know what you think and if I can open the PR for the review. |
Nice yeah I think you can open it up for review |
@madmax330 could you assign me here? thanks |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-19. 🎊 For reference, here are some details about the assignees on this issue:
|
Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks! |
Payment Summary
BugZero Checklist (@puneetlath)
|
Closing as the payment summary above is correct. @getusha please request on NewDot. |
$250 approved for @getusha |
Part of the project
Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.2gdskq5ha42g
Project: https://github.com/orgs/Expensify/projects/114/views/3
Feature Description
Relevant doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#bookmark=id.f3av6bmd6vy6
Manual Test Steps
Create an invoice and make sure that if we don't already have company name and website collected then we ask the user to enter it
Automated Tests
The text was updated successfully, but these errors were encountered: