[PAID] [$250] QBO - Tags - Error message is missing left and right margins and cannot be dismissed

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5-5
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace A is connected to QBO and has imported multi tags.
• Workspace B is not connected to QBO and has tags (not multi tags).

1. Go to staging.new.expensify.com
2. Go to Workspace B settings > Tags.
3. Click Settings > Custom tag name.
4. Enter 0 and save it.
5. Note that the error message has left and right margins and can be dismissed.
6. Go to Workspace A settings (the one connected to QBO) > Tags.
7. Click on any main tag > Custom tag name.
8. Enter 0 and save it.
9. Click on the X button.

Expected Result:

The error message will have left and right margins and can be dismissed.

Actual Result:

The error message does not have left and right margins and cannot be dismissed when clicking on the X button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6536555_1720498506705.bandicam_2024-07-09_12-10-34-149.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0100255cf25234fe2e
• Upwork Job ID: 1810657313224383264
• Last Price Increase: 2024-07-09
• Automatic offers:
• ShridharGoel | Contributor | 103046084

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Crash on production

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

QBO - Tags - Error message is missing left and right margins and cannot be dismissed

What is the root cause of that problem?

Styles are not set in OfflineWithFeedback + onClose logic is missing.

App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

Lines 253 to 256 in 7c37886

	<OfflineWithFeedback
	errors={currentPolicyTag.errors}
	pendingAction={currentPolicyTag.pendingAction}
	>

What changes do you think we should make in order to solve the problem?

Update it to this:

<OfflineWithFeedback
    errors={currentPolicyTag.errors}
    onClose={() => Tag.clearPolicyTagListErrors(policyID, currentPolicyTag.orderWeight)}
    pendingAction={currentPolicyTag.pendingAction}
    errorRowStyles={styles.mh5}
>

[danieldoglas]

Doesn't look related to backend changes.

[Julesssss]

Hi @ShridharGoel, your proposal makes sense to me. As this is a blocker, please could you raise a PR ASAP and I'll assign you.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0100255cf25234fe2e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ShridharGoel]

Opening it in few minutes.

[ShridharGoel]

@Julesssss @lakchote #45068

[kbecciv]

Issue is not reproducible

bandicam.2024-07-09.18-47-34-410.mp4

[ShridharGoel]

@strepanier03 Can you handle the payments on this? Thanks.

[melvin-bot]

This issue has not been updated in over 15 days. @Julesssss, @strepanier03, @ShridharGoel eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!