Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - Change password - "New Expensify accounts" displayed instead "new.expensify.com" under Change Password #4482

Closed
kavimuru opened this issue Aug 6, 2021 · 5 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Aug 6, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing the PR #4091

Action Performed:

  1. Sign into the app
  2. Go to settings
  3. Go to reset password

Expected Result:

Verify the copy mentions "new.expensify.com"

Actual Result:

"New Expensify accounts" displayed instead 'new.expensify.com" under Change Password.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
1.0.83-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5182652_account

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Aug 6, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@chiragsalian chiragsalian self-assigned this Aug 7, 2021
@chiragsalian chiragsalian added the Reviewing Has a PR in review label Aug 7, 2021
@chiragsalian
Copy link
Contributor

PR in review

@chiragsalian
Copy link
Contributor

Oh actually maybe my changes are not required looks like there is a thread where we discussed and wanted it to be New Expensify.
I'll let @tgolen and @kevinksullivan confirm and if so we can just close this issue.

@kevinksullivan
Copy link
Contributor

yeah, this wording / difference is correct. Going to close out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants