[HOLD for payment 2024-08-01] [Workspace Feeds] [External] Create a modal for Expensify Card Enabled empty state

[mountiny]

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

[koko57]

Taking this issue 😊

[koko57]

I will take another issue as we can put this one on hold for this PR #44137 - I will use a component created there instead the ConfirmModal (more info here)

[mountiny]

This is off hold now

[koko57]

@shawnborton I see that the component created in #44137 accepts either a lottie animation, video or an svg. How should be this asset exported?

[shawnborton]

Fairly certain this one is just static, so just an .svg would do? Let me try to export something for you...

[shawnborton]

Let's try this and see if it works? emptystate__expensifycard.svg.zip

cc @Expensify/design - tried to make this an actual svg with no pngs embedded or anything, let's see how it goes!

[koko57]

Thanks for the file! Still working on it 🙂

[koko57]

@shawnborton I've just noticed that the screenshot element in the svg you exported doesn't have rounded corners

Could you check why they're not rounded and export a new version please?🙏🏻

[shawnborton]

Ah good catch! Here is an updated version: emptystate__expensifycard.svg.zip

[koko57]

Fighting a bit with svg size on mobile, but it's almost ready (PR in draft)

[mountiny]

This was merged 🎉

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Empty state modal #45690

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @JmillsExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @koko57 is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

$250 for @DylanDylann for PR review and testing.

[DylanDylann]

@JmillsExpensify No need for payment here. This belongs to project

[JmillsExpensify]

Oh ok cool thanks! Closing then.