[HOLD for payment 2024-08-27] [$250] Web - Split - Enter and CMD+Enter open user profile instead of splitting expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1.Go to staging.new.expensify.com
2. Go to group chat.
3. Go to + > Split expense.
4. Enter amount > Next.
5. On confirmation page, hit Enter or CMD+Enter.

---

Note

In the same flow also from any of the amounts clicking Enter should confirm the split

Expected Result:

Enter or CMD+Enter will split the expense.

Actual Result:

Enter or CMD+Enter opens the profile of the last user under "Split amounts" list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6474634_1715160446644.20240508_171210.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010103e80036688f64
• Upwork Job ID: 1788212648413052928
• Last Price Increase: 2024-08-27
• Automatic offers:
• abzokhattab | Contributor | 0
• Krishna2323 | Contributor | 102703476

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010103e80036688f64

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Split - Enter and CMD+Enter open user profile instead of splitting expense

What is the root cause of that problem?

The condition for calling onConfirmSelection is wrong, it should not check for canSelectMultipleOptions.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 325 to 328 in e0b6a06

	if (this.props.canSelectMultipleOptions) {
	this.props.onConfirmSelection();
	return;
	}

What changes do you think we should make in order to solve the problem?

Instead of canSelectMultipleOptions we need to check for onConfirmSelection.

What alternative solutions did you explore? (Optional)

[mountiny]

@Krishna2323 Thanks, which PR is this coming from?

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split - Enter and CMD+Enter open user profile instead of splitting expense

What is the root cause of that problem?

Two problems here:

1. pressing on enter doesn't confirm the split:
   we are intentionally making the priority of the settlement button as 1 here which is not needed after this PR

2. pressing ctrl + enter doesn't confirm:
   the ctrl + enter is enabled by the OptionsSelector, so on order to confirm instead of opening the user details
   we need to pass the canSelectMultipleOptions as true here ... the offending PR is this

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 325 to 328 in e0b6a06

	if (this.props.canSelectMultipleOptions) {
	this.props.onConfirmSelection();
	return;
	}

What changes do you think we should make in order to solve the problem?

1. remove the enterKeyEventListenerPriority={1} prop here
2. add the canSelectMultipleOptions prop to the OptionsSelector here

[mountiny]

I was just looking into that PR, I dont think we can revert it, we should look into a fix

[CortneyOfstad]

@lschurr I am heading OoO so reassigned. Payment will most likely be delayed due to new PR here, but wanted someone assigned just in case. Thanks!

[lschurr]

New PR is still open: #46278

[melvin-bot]

@mananjadhav, @johnmlee101, @CortneyOfstad, @lschurr, @mountiny, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

PR was merged

[melvin-bot]

@mananjadhav, @johnmlee101, @CortneyOfstad, @lschurr, @mountiny, @Krishna2323 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mananjadhav]

I think this is ready for payout, but we've had regression on this one.

cc - @CortneyOfstad @mountiny

[mananjadhav]

@CortneyOfstad @mountiny quick bump if you missed.

[melvin-bot]

Upwork job price has been updated to $250

[mountiny]

@lschurr @CortneyOfstad This is ready to be paid. This was originally for $500, but there was a regression so we are cutting the price in half.

$250 to @mananjadhav and to @Krishna2323 please

[lschurr]

Payment summary:

• Contributor: $250 @Krishna2323 (Paid in Upwork)
• Reviewer: $250 @mananjadhav (Please request via NewDot)

[CortneyOfstad]

Thank you @lschurr!!

[garrettmknight]

$250 approved for @mananjadhav