Expense - Add receipt placeholder is shown for admin but not employee for paid expense

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: Applause-Internal team
Issue reported by:

Action Performed:

1. Go to staging.new.expensify.com
2. [Employee] Submit a manual expense in the workspace chat.
3. [Admin] Approve and pay elsewhere the request.
4. [Employee and admin] Go to the paid transaction thread.

Expected Result:

There should be consistency in whether the add receipt placeholder should be shown in the paid transaction thread for admin and employee.

Actual Result:

Add receipt placeholder is shown for admin but not employee for paid expense.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6467844_1714563553245.20240501_193424.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@miljakljajic I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[miljakljajic]

@amyevans does this seem like BE to you, or can I put the external label on?

[amyevans]

Dev/staging:

Prod:

From the looks of it this was an intentional change, introduced in this PR: #37813, with the logic contained in this line:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 331 in 2eda4bd

const shouldShowReceiptEmptyState = !hasReceipt && !isInvoice && (canEditReceipt || isAdmin || isApprover);

We now show the receipt empty state if you are an admin or approver.

Versus on production the logic is:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 362 to 377 in 9b4da0d

	{!hasReceipt && canEditReceipt && (
	<ReceiptEmptyState
	hasError={hasErrors}
	onPress={() =>
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
	CONST.IOU.ACTION.EDIT,
	iouType,
	transaction?.transactionID ?? '',
	report.reportID,
	Navigation.getActiveRouteWithoutParams(),
	),
	)
	}
	/>
	)}

Definitely not a blocker either way. I'd like confirmation this is the expected behavior though from someone more closely involved in the Receipt Audit feature/PR @cead22 @JmillsExpensify. If it is we can close this out!

[cead22]

@amyevans I think you're right and we can close this, but let's wait for Jason to confirm

[melvin-bot]

@amyevans, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[miljakljajic]

@JmillsExpensify - what do you think? Shall we close?

[melvin-bot]

@amyevans, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@amyevans, @miljakljajic Still overdue 6 days?! Let's take care of this!

[miljakljajic]

Closing - feel free to reopen if you feel strongly otherwise!