[HOLD for payment 2024-05-08] [HOLD for payment 2024-05-06] Public room - "Message Concierge for help with setup" banner appears for anonymous user

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #40701
Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Log out if logged in.
3. Navigate to a public room link (https://staging.new.expensify.com/r/2376199970894587).

Expected Result:

"Message Concierge for help with setup" banner will not appear for anonymous user viewing the public room.

Actual Result:

"Message Concierge for help with setup" banner appears for anonymous user viewing the public room.
This banner also disappears after delay after logging in to public room.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

6463583.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@iwiznia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #vip-vsb

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Public room - "Message Concierge for help with setup" banner appears for anonymous user

What is the root cause of that problem?

We dont check for anonymous user when displaying the SystemChatReportFooterMessage Report Footer

What changes do you think we should make in order to solve the problem?

We should add a check for !isAnonymousUser when displaying the banner here:

App/src/pages/home/report/ReportFooter.tsx

Line 144 in 10fc359

{!canWriteInReport && <SystemChatReportFooterMessage />}

{!isAnonymousUser && !canWriteInReport && <SystemChatReportFooterMessage />} 

Alternatively

We can add the is anonyous user check to ReportUtils.canWriteInReport(report); or just to the canWriteInReport variable here:

App/src/pages/home/report/ReportFooter.tsx

Line 85 in 10fc359

const canWriteInReport = ReportUtils.canWriteInReport(report);

[iwiznia]

This seems to be coming from #40010
@rezkiy37 do you want to take a look or should I revert that PR?

[iwiznia]

Asked here https://expensify.slack.com/archives/C01GTK53T8Q/p1714399960286809

[neonbhai]

This will be fixed with #41200

@iwiznia @isabelastisser

[iwiznia]

Oh ok

[isabelastisser]

@iwiznia @neonbhai, does it mean that this issue can be closed?

[neonbhai]

We aren't proceeding with the revert, just changing visiblity logic (ref: here)

We could keep it open so it is tested for regressions after deploy?

cc: @isabelastisser

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: System Footer Visibility #41200

If no regressions arise, payment will be issued on 2024-05-06. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
• [@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@iwiznia] Determine if we should create a regression test for this bug.
• [@iwiznia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: System Footer Visibility #41200

If no regressions arise, payment will be issued on 2024-05-08. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
• [@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@iwiznia] Determine if we should create a regression test for this bug.
• [@iwiznia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[isabelastisser]

@iwiznia, can I close this or do you need to complete the BZ list above first?