[$250] Update report actions in CONST.ts to use underscores for readability

[marcaaron]

cc @roryabraham This is not really related to Group Chats, but came about in a PR review so creating a ticket to have it cleaned up.

Problem:

In App we have report action strings in CONST.ts that are not using underscores. This makes readability difficult and is inconsistent with the backend code where the same report actions exist and include underscores.

Solution:

Update the consts from here and all references to use underscores to break up the words e.g.

ACTIONABLEMENTIONWHISPER -> ACTIONABLE_MENTION_WHISPER
ADDCOMMENT -> ADD_COMMENT

etc.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01610cbc887eeeda07
• Upwork Job ID: 1778880452173856768
• Last Price Increase: 2024-04-12
• Automatic offers:
• fedirjh | Reviewer | 0
• shahinyan11 | Contributor | 0

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01610cbc887eeeda07

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[shahinyan11]

Dibs

[shahinyan11]

Is need to make proposal here?

[marcaaron]

Nope you're in 😄

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @shahinyan11 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[fedirjh]

Update the consts from here and all references to use underscores to break up the words e.g.

ACTIONABLEMENTIONWHISPER -> ACTIONABLE_MENTION_WHISPER ADDCOMMENT -> ADD_COMMENT

cc @marcaaron Are we updating both the keys and values?

// Old 
ADDCOMMENT: 'ADDCOMMENT',

// New ? 
ADD_COMMENT: 'ADD_COMMENT', // Update both key and value 
ADD_COMMENT: 'ADDCOMMENT', // OR update just keys ?

[roryabraham]

just keys, not values

[melvin-bot]

This issue has not been updated in over 15 days. @garrettmknight, @marcaaron, @fedirjh, @shahinyan11 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[fedirjh]

cc @garrettmknight This is already deployed to prod and it's overdue payment.

[garrettmknight]

Payment Summary

• Contributor: @shahinyan11 $250 paid via upwork
• Reviewer: @fedirjh $250 paid via upwork

Sorry about that! @fedirjh you think this could use a new QA test?

[fedirjh]

you think this could use a new QA test?

@garrettmknight No, this is simply code refactoring done to enhance readability.