-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat - Second and subsequent messages not displayed in chat until chat reloaded #39650
Comments
Triggered auto assignment to @hayata-suenaga ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
This definitely just seems like a case of Pusher being really slow to send the updates, I don't think this needs to be a blocker since if there is a problem it exists in the back-end anyways. Still probably a good thing to investigate, |
In the video it looks like pusher events with the report updates are reaching the other client, but the report actions maybe not? The steps are somewhat confusing to me when it mixes account A/B and main/secondary device. Is the "secondary/main device" only mentioned to say that both accounts are logged in simultaneously in different devices? |
@lanitochka17 is this step wrong?
The "account A" is supposed to be using the "main device", right? |
Reproduced |
I can see that the
The receiver account is 16596361 (aldo+test39650-account-a@expensifail.com) When looking in dev tools > Application > keyvaluepair > I can see in the console that the event with the comment did reach the front end:
but somehow it wasn't applied in Onyx? 🤷 X 1000 |
Tried to reproduce in dev using |
Asked in slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1712274581354349 The cause seems to be this PR #38997. Testing the ad-hoc build with the revert #39668 makes the problem disappear. I also noticed that in staging, when the bug happens, the following log lines never appear:
|
This is fixed now: #39668 (comment) |
thank you Aldo for triaging this issue. Removing myself from assignment as I didn't fix the issue |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.60-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #34902
Action Performed:
Precondition: user signed up with a new account A on the main testing device and account B on secondary device or app
Expected Result:
All messages should be displayed in chat. Second and subsequent messages are missing
Actual Result:
Only first message displayed in chat. The second and subsequent messages missing until chat will be reloaded
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6438253_1712260999641.Screen_Recording_2024-04-04_at_22.57.08.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: