[HOLD for payment 2024-04-15] BNP - Unable to enter number on BNP unless the number 0.00 is erased first

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Request money > Manual.
3. Enter any number.

Expected Result:

User should be able to enter number without erasing the number first on BNP.

Actual Result:

User is unable to enter number on BNP unless the number 0.00 is erased first.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437918_1712233906561.BNP.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Offended PR #35797

issue here: 8e80ffb

What changes do you think we should make in order to solve the problem?

The initial amount shoud be 0 and not 0.00

App/src/pages/iou/steps/MoneyRequestAmountForm.tsx

Line 130 in 0b2f55f

const frontendAmount = CurrencyUtils.convertToFrontendAmountAsString(newAmount);

const  frontendAmount  =  newAmount  ?  CurrencyUtils.convertToFrontendAmountAsString(newAmount) :  '';

[iwiznia]

Going to revert the offending PR

[iwiznia]

Not a blocker anymore since we reverted the PR here #39610

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Current assignee @iwiznia is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[iwiznia]

Just realized I removed the blocker without re-test, @kbecciv can you please retest this?
Once we confirm is good, we can remove the blocker

[m-natarajan]

@iwiznia Issue is fixed now.

20240405_042747.mp4

[iwiznia]

Thank you!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "35797-preserving-the-transactions-amounts-the-same-as-entered" #39610

If no regressions arise, payment will be issued on 2024-04-15. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@iwiznia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!