[HOLD for payment 2024-04-15] [$500] Kill ReconnectToReport

[aldo-expensify]

In the context of optimizing ReconnectToReport, we are proposing to just get rid of it since it became redundant after reliable updates was implemented.

ReconnectToReport command was introduced to get the missing reportActions after coming back online. This was necessary because ReconnectApp didn't get reportActions, but now that we have "reliable updates", we are able to fetch and retrieve the missed Onyx updates which contain the missing report Actions (The missed updates are returned by ReconnectApp).

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

With a report open, go offline and the online again

Expected Result:

Looking at the network requests, we should only see a ReconnectApp request and not a ReconnectToReport request

Actual Result:

ReconnectToReport is there, is sometimes slow and is useless.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aldo-expensify]

Adding @c3024 in the role of C+ to review the PR #34902

[lschurr]

It looks like the linked PR was merged but isn't deployed to prod yet. Once it is, the payment date will be set.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• HIGH: Kill ReconnectToReport #34902

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[lschurr]

Offer sent to @c3024 in Upwork - https://www.upwork.com/nx/wm/offer/101841684

[c3024]

@lschurr accepted. Thanks.

[lschurr]

Payment summary:

• $500 to @c3024 (paid in Upwork)