IOU - Add receipt thumbnail is grayed out in combined report but not in transaction thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline
3. Request money from user that has no unsettled IOU
4. Go to combined IOU report
5. Note that the add receipt thumbnail is grayed out
6. Create another IOU request
7. Go to transaction thread
8. Note that the add receipt thumbnail is not grayed out

Expected Result:

There should be consistency in whether to gray out add receipt thumbnail in combined report and transaction thread when request is created offline

Actual Result:

Add receipt thumbnail in combined report (Steo 4) is grayed out, but it is not grayed out in transaction thread (Step 7)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435765_1712075127792.20240403_002056.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[NikkiWines]

I think this is resolved by #39433 - retesting now

[NikkiWines]

Ok, it isn't but it's a pretty minor bug and probably doesn't need to be a blocker. The PR to resolve this is here

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @NikkiWines, @stitesExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[stitesExpensify]

Ok, it isn't but it's a pretty minor bug and probably doesn't need to be a blocker. The PR to resolve this is here

@NikkiWines since that was merged is this fixed now?

[NikkiWines]

Yes, I believe this is resolved - though not by that PR in the end (see here for more context). This can be closed out.