Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting payment a while ago] System message for approval has no Spanish translation #39200

Closed
1 of 6 tasks
m-natarajan opened this issue Mar 28, 2024 · 20 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@m-natarajan
Copy link

m-natarajan commented Mar 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711593424889649

Action Performed:

  1. Set user a’s app preferences to Spanish
  2. Submit a request as user a
  3. Have user b approve the request from user a

Expected Result:

System message are translated in Spanish, if that is the user’s language preference

Actual Result:

The approval system message isn’t translated, while other system messages are

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

CleanShot 2024-03-27 at 21 29 26@2x

Screen Shot 2024-03-28 at 1 22 38 PM

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012ebbcb5ad5a18675
  • Upwork Job ID: 1773410815992803328
  • Last Price Increase: 2024-03-28
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@marcochavezf marcochavezf self-assigned this Mar 28, 2024
@marcochavezf
Copy link
Contributor

Assigning myself, since it's related to the collect approvers implementation and requires an internal fix

@marcochavezf marcochavezf added the Internal Requires API changes or must be handled by Expensify staff label Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012ebbcb5ad5a18675

Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @dukenv0307 (Internal)

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@isabelastisser
Copy link
Contributor

Added to wave-collect.

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2024
@marcochavezf
Copy link
Contributor

I think this can be considered a polish issue, I will move it to weekly to focus on other higher-priority issues, but feel free to change if you disagree

@marcochavezf marcochavezf added Weekly KSv2 and removed Daily KSv2 labels Apr 2, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

@marcochavezf @isabelastisser @dukenv0307 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@isabelastisser
Copy link
Contributor

Not overdue.

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@marcochavezf
Copy link
Contributor

marcochavezf commented Apr 22, 2024

No update, working on a hold request bug and awareness campaign for track expense newsletter

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 30, 2024
@isabelastisser
Copy link
Contributor

No updates.

@melvin-bot melvin-bot bot removed the Overdue label Apr 30, 2024
@isabelastisser isabelastisser added Monthly KSv2 and removed Weekly KSv2 labels Apr 30, 2024
@isabelastisser isabelastisser changed the title System message for approval has no Spanish translation [HOLD] System message for approval has no Spanish translation Apr 30, 2024
@isabelastisser
Copy link
Contributor

@marcochavezf, I will put this on hold until you're able to prioritize it. Thanks!

@marcochavezf
Copy link
Contributor

No update, we will need to merge first https://github.com/Expensify/Auth/pull/10883

@isabelastisser
Copy link
Contributor

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Jun 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 Overdue labels Jul 8, 2024
@marcochavezf marcochavezf changed the title [HOLD] System message for approval has no Spanish translation System message for approval has no Spanish translation Jul 8, 2024
@marcochavezf
Copy link
Contributor

PR up

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

This issue has not been updated in over 15 days. @marcochavezf, @isabelastisser, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@isabelastisser
Copy link
Contributor

@marcochavezf, what are the next steps here? All done?

@trjExpensify
Copy link
Contributor

Yep, but @dukenv0307 reviewed the PR and needs paying @isabelastisser

@trjExpensify trjExpensify added Daily KSv2 and removed Reviewing Has a PR in review Monthly KSv2 labels Sep 3, 2024
@trjExpensify trjExpensify added the Awaiting Payment Auto-added when associated PR is deployed to production label Sep 3, 2024
@trjExpensify trjExpensify changed the title System message for approval has no Spanish translation [Awaiting payment a while ago] System message for approval has no Spanish translation Sep 3, 2024
@isabelastisser
Copy link
Contributor

@dukenv0307, I sent you an offer in Upwork now. Please accept it and I will process the payment. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2024
@isabelastisser
Copy link
Contributor

All set so closing this.

@dukenv0307
Copy link
Contributor

dukenv0307 commented Sep 7, 2024

Please accept it and I will process the payment.

@isabelastisser I accepted the offer, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
Status: Done
Development

No branches or pull requests

5 participants