Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ON HOLD #47203] [HIGH] [$500] mWeb - Composer-App crashes/freezes when pasting copied image inside the compose box #36909

Closed
1 of 6 tasks
kbecciv opened this issue Feb 20, 2024 · 49 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Feb 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4331256
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go inside your device gallery and copy an image to your clipboard
  2. Open ND app and click inside the compose box and hold down until you see the option to paste
  3. Click on paste
  4. While the app is stuck try to interact with the app (for example try to close the keyboard, click inside the compose box or anywhere)

Expected Result:

App should function normally and paste the image

Actual Result:

App freezes and then crashes eventually

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385684_1708433272308.App_crash_pasting_image.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0131dabafc5db30095
  • Upwork Job ID: 1761017840885219328
  • Last Price Increase: 2024-08-21
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 20, 2024

@CortneyOfstad I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@melvin-bot melvin-bot bot added the Overdue label Feb 22, 2024
@CortneyOfstad
Copy link
Contributor

Thanks @kbecciv! I've been diving into this and I think that this could be handled by an external contrubutor 👍

@melvin-bot melvin-bot bot removed the Overdue label Feb 23, 2024
@CortneyOfstad CortneyOfstad added the External Added to denote the issue can be worked on by a contributor label Feb 23, 2024
@melvin-bot melvin-bot bot changed the title mWeb - Composer-App crashes/freezes when pasting copied image inside the compose box [$500] mWeb - Composer-App crashes/freezes when pasting copied image inside the compose box Feb 23, 2024
Copy link

melvin-bot bot commented Feb 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0131dabafc5db30095

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 23, 2024
Copy link

melvin-bot bot commented Feb 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

@CortneyOfstad
Copy link
Contributor

@eh2077 Please let me know if you have any concerns about this potentially being a BE Issue, and we can get that tags switched. From what I could see, it appears not to be, but would love fresh eyes just in case 👍

@eh2077
Copy link
Contributor

eh2077 commented Feb 23, 2024

@CortneyOfstad Yeah, this is most likely an issue from frontend.

@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@CortneyOfstad
Copy link
Contributor

Posted in VIP-VSB here

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

@CortneyOfstad, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@CortneyOfstad CortneyOfstad changed the title [$500] mWeb - Composer-App crashes/freezes when pasting copied image inside the compose box [HIGH] [$500] mWeb - Composer-App crashes/freezes when pasting copied image inside the compose box Feb 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 28, 2024
@CortneyOfstad
Copy link
Contributor

Going to reach out to CallStack to see if someone can take this on 👍

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
@CortneyOfstad
Copy link
Contributor

Post to CS here

Copy link

melvin-bot bot commented Mar 1, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@badeggg
Copy link
Contributor

badeggg commented Mar 5, 2024

Some information if it help. I can't reproduce the bug. In the gallery app(which I downloaded from google play), there is no 'copy to clipboard' option, I tried 3~4 apps. Finally I noticed in app swiper we can copy image to clipboard. When I copy the image to composer of expensify, everything works fine. I am a ios user and rarely use android device by the way.

@eh2077
Copy link
Contributor

eh2077 commented Mar 5, 2024

@badeggg Thanks for looking into this! I think the photo app is Samsung Gallery. You can search keyword Gallery or Samsung Gallery in the playstore to download one.

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2024
@mountiny
Copy link
Contributor

Discussed with @trjExpensify too, for now I think we can close this, its not that often used feature and we can spend our time in better manner now so closing and we can reopen once we ready to implement this

@lanitochka17
Copy link

Issue is still reproducible on the latest build 9.0.20-2

Screen_Recording_20240814_154411_New.Expensify.mp4

@lanitochka17 lanitochka17 reopened this Aug 14, 2024
@eh2077
Copy link
Contributor

eh2077 commented Aug 14, 2024

Did #41239 solve this issue?

Copy link

melvin-bot bot commented Aug 14, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@CortneyOfstad
Copy link
Contributor

Still waiting for #47203 to hit production, so going to put this on-hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@CortneyOfstad CortneyOfstad changed the title [HIGH] [$500] mWeb - Composer-App crashes/freezes when pasting copied image inside the compose box [ON HOLD #47203] [HIGH] [$500] mWeb - Composer-App crashes/freezes when pasting copied image inside the compose box Aug 19, 2024
Copy link

melvin-bot bot commented Aug 21, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2024
@CortneyOfstad
Copy link
Contributor

Okay, botify is sick, so the move to production was done manually without an update to the PR. It went into Production 2 days, ago so the 7-day wait period is over on Aug. 26!

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Aug 23, 2024
@CortneyOfstad
Copy link
Contributor

The hold period for production has been completed so this can be closed!

@s77rt
Copy link
Contributor

s77rt commented Aug 26, 2024

Let's keep this one open, it seems to be reproducible on Samsung devices only. cc @ahmedGaber93 can you please confirm this is still reproducible from your end

@ahmedGaber93
Copy link
Contributor

can you please confirm this is still reproducible from your end

It reproduced on production, and I will retest the latest main branch today.

@ahmedGaber93
Copy link
Contributor

@s77rt The feature itself is not working with me on android (on both emulator and real device) after RN upgrading to 0.75.2.

20240829031128673.mp4

@s77rt
Copy link
Contributor

s77rt commented Aug 29, 2024

@ahmedGaber93 Can you try remove the node_modules/react-native folder and reinstall, it's possible that the patch is not being applied in your case

@ahmedGaber93
Copy link
Contributor

Can you try remove the node_modules/react-native folder and reinstall, it's possible that the patch is not being applied in your case

@s77rt Yes, I already did that before the build. And I think the patch is applied correctly because it works fine on iOS

@s77rt
Copy link
Contributor

s77rt commented Aug 29, 2024

Indeed, looks like something broke it. Will take a look asap

@s77rt
Copy link
Contributor

s77rt commented Aug 30, 2024

@ahmedGaber93 The patch fix #48370

@ahmedGaber93
Copy link
Contributor

ahmedGaber93 commented Sep 2, 2024

can you please confirm this is still reproducible from your end

@s77rt Yes, it still reproduced on real Samsung device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

10 participants