Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-19] HIGH: [$500] Magic link - Can't sign in using magic link after going to public room via deeplink #36812

Closed
1 of 6 tasks
isagoico opened this issue Feb 19, 2024 · 34 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@isagoico
Copy link

isagoico commented Feb 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.42.0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Issue reported by: Applause -Internal team
Slack conversation: Found while executing tests for https://expensify.slack.com/archives/C9YU7BX5M/p1708359665549809

Action Performed:

  1. Sign out (if needed) from the app (And kill the app)
  2. Navigate to this public room from another app: https://staging.new.expensify.com/r/6776919265133947
  3. Click on sign in
  4. Open gmail app and click on the sign in magic link

Expected Result:

App should automatically sign the user in

Actual Result:

App doesn't automatically sign the user in after clicking on magic link. user has to use magic code to sign in

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6384808_1708366829777.Screen_Recording_20240219_202408_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01502a04f32100df3d
  • Upwork Job ID: 1760726284749012992
  • Last Price Increase: 2024-03-07
Issue OwnerCurrent Issue Owner: @zanyrenney
Issue OwnerCurrent Issue Owner: @zanyrenney
@isagoico isagoico added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@isagoico
Copy link
Author

isagoico commented Feb 19, 2024

We think this might be related to #36811 but we were not sure. Seems like deeplinking doesn't work twice in a row or just when the app is open in the background.

@mallenexpensify
Copy link
Contributor

Thanks @isagoico, adding to #vip-vsb project.

@melvin-bot melvin-bot bot added the Overdue label Feb 22, 2024
@zanyrenney zanyrenney added the External Added to denote the issue can be worked on by a contributor label Feb 22, 2024
@melvin-bot melvin-bot bot changed the title Magic link - Can't sign in using magic link after going to public room via deeplink [$500] Magic link - Can't sign in using magic link after going to public room via deeplink Feb 22, 2024
Copy link

melvin-bot bot commented Feb 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01502a04f32100df3d

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 22, 2024
Copy link

melvin-bot bot commented Feb 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 22, 2024
@zanyrenney
Copy link
Contributor

Triaged, thanks for adding to #VIPVSB

@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

@jjcoffee, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@jjcoffee
Copy link
Contributor

Waiting for proposals!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 26, 2024
@zanyrenney
Copy link
Contributor

still waiting on proposals.

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
Copy link

melvin-bot bot commented Mar 4, 2024

@jjcoffee @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@zanyrenney
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@quinthar quinthar changed the title [$500] Magic link - Can't sign in using magic link after going to public room via deeplink HIGH: [$500] Magic link - Can't sign in using magic link after going to public room via deeplink Mar 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

❌ There was an error making the offer to @jjcoffee for the Reviewer role. The BZ member will need to manually hire the contributor.

Copy link

melvin-bot bot commented Mar 7, 2024

❌ There was an error making the offer to @bernhardoj for the Contributor role. The BZ member will need to manually hire the contributor.

@flodnv
Copy link
Contributor

flodnv commented Mar 7, 2024

@zanyrenney ^ 😕

@bernhardoj
Copy link
Contributor

Let's fix these comments while we're here: #29248 (review)

Addressed in the PR.

PR is ready

cc: @jjcoffee

@zanyrenney
Copy link
Contributor

@jjcoffee @bernhardoj invited you manually to the upwork job, please accept so we can payout when the time comes.

@jjcoffee
Copy link
Contributor

@zanyrenney Applied! 🙏

@bernhardoj
Copy link
Contributor

Applied

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 12, 2024
@melvin-bot melvin-bot bot changed the title HIGH: [$500] Magic link - Can't sign in using magic link after going to public room via deeplink [HOLD for payment 2024-03-19] HIGH: [$500] Magic link - Can't sign in using magic link after going to public room via deeplink Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-19. 🎊

For reference, here are some details about the assignees on this issue:

  • @jjcoffee requires payment (Needs manual offer from BZ)
  • @bernhardoj requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Mar 12, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
  • [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@jjcoffee] Determine if we should create a regression test for this bug.
  • [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@zanyrenney
Copy link
Contributor

offers sent to @jjcoffee and @bernhardoj on UW ahead of payment tomorrow.

@zanyrenney
Copy link
Contributor

Hmm sctually the offer to @jjcoffee is timing out :
2024-03-18_17-39-21

I will do a clean signout tonight and resend.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 18, 2024
@zanyrenney
Copy link
Contributor

payment summary

paid $500 to @bernhardoj
offer sent to @jjcoffee

Copy link

melvin-bot bot commented Mar 19, 2024

Payment Summary

Upwork Job

BugZero Checklist (@zanyrenney)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1760726284749012992/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@jjcoffee
Copy link
Contributor

@zanyrenney Accepted the offer, thanks!

@zanyrenney
Copy link
Contributor

payment summary

paid $500 to @bernhardoj
paid $500 to @jjcoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

6 participants