[$500] IOU - System message is not shown after completing send money request flow

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.42
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab ---- send money
3. Enter an amount and tap next
4. Select an user
5. Tap pay elsewhere
6. Tap on send money request created to open report page

Expected Result:

After completing send money request flow, in IOU report page, for paid system message must be displayed

Actual Result:

After completing send money request flow, in IOU report page, for paid system message is not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6381235_1708031779004.msg.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019999a8d5ba73ff93
• Upwork Job ID: 1758251251823669248
• Last Price Increase: 2024-02-15

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019999a8d5ba73ff93

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

Production:

noy.mp4

[lanitochka17]

We think that this bug might be related to #vip-bills
CC @davidcardoza

[kameshwarnayak]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - System message is not shown after completing send money request flow

What is the root cause of that problem?

We are forcefully ignoring markedAsReimbursed actions and not displaying it.

App/src/libs/ReportActionsUtils.ts

Lines 396 to 400 in 9843f66

	// Ignore markedAsReimbursed action here since we're already display message that explains the request was paid
	// elsewhere in the IOU reportAction
	if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.MARKEDREIMBURSED) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

Removing the above code will fix the issue.

Result:

Screen.Recording.2024-02-16.at.10.36.20.AM.mov

What alternative solutions did you explore? (Optional)

NA

[thienlnam]

cc @Gonals Looks like you added this in #34719, was this an intentional change and if so should we update the testrail?

[Gonals]

This is not a bug. It is intended behavior. The relevant message is already displayed in the IOU action. Closing