Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Task - Extra space between [Deleted task] and message in task thread #36017

Closed
2 of 6 tasks
kbecciv opened this issue Feb 7, 2024 · 8 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Feb 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v.1.4-38.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to 1:1 DM.
  3. Create a task.
  4. Go to task thread.
  5. Send a message.
  6. Delete the task.

Expected Result:

There will be no extra space between [Deleted task] and message in task thread.

Actual Result:

There is extra space between [Deleted task] and message in task thread.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370303_1707308038137.Screen_Recording_20240207_123634_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bc95f54b175bf754
  • Upwork Job ID: 1755217480049831936
  • Last Price Increase: 2024-02-07
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 7, 2024
@melvin-bot melvin-bot bot changed the title Task - Extra space between [Deleted task] and message in task thread [$500] Task - Extra space between [Deleted task] and message in task thread Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bc95f54b175bf754

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

Copy link

melvin-bot bot commented Feb 7, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 7, 2024

We think that this bug might be related #vip-vsb
CC @quinthar

@dukenv0307
Copy link
Contributor

dukenv0307 commented Feb 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is extra space between [Deleted task] and message in task thread.

What is the root cause of that problem?

We incorrectly added this style

<View style={[StyleUtils.getReportWelcomeContainerStyle(props.isSmallScreenWidth, true)]}>
, it's supposed to be only for the non-deleted task report.

What changes do you think we should make in order to solve the problem?

Restore it to

<>
</>

What alternative solutions did you explore? (Optional)

Add styles.justifyContentEnd here

@paultsimura
Copy link
Contributor

It was caught by @situchan here: #35232 (comment)

Will be handled in #33922 as per #35232 (comment)

@situchan
Copy link
Contributor

situchan commented Feb 7, 2024

yes dupe

@puneetlath
Copy link
Contributor

Ok thanks y'all. Closing as a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants