Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-20] [Simplified Collect][Profile] Update name convention from Overview to Profile for all workspace level items like components, functions, routes, etc. #35718

Closed
luacmartins opened this issue Feb 2, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 2, 2024

Implement Update name convention from Overview to Profile for all workspace level items like components, functions, routes, etc. from the Simplified Collect: Profile, Members, Categories design doc

Issue OwnerCurrent Issue Owner: @narefyev91
@luacmartins luacmartins added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels Feb 2, 2024
@luacmartins luacmartins self-assigned this Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 2, 2024
@luacmartins
Copy link
Contributor Author

@narefyev91 can you please comment here so I can assign you to the issue?

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 2, 2024
@luacmartins luacmartins changed the title [Simplified Collect] [Profile] Update name convention from Overview to Profile for all workspace level items like components, functions, routes, etc. [Simplified Collect][Profile] Update name convention from Overview to Profile for all workspace level items like components, functions, routes, etc. Feb 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@narefyev91
Copy link
Contributor

narefyev91 commented Feb 5, 2024

Hi! I'm Nicolay from Callstack - expert contributor group. I'll work on this issue so please assign me. Thank you.

@narefyev91
Copy link
Contributor

Today updates - start working on Refactoring naming convention. Will continue tomorrow as well. No blockers for now!

@trjExpensify
Copy link
Contributor

Wahoo! Let's get it!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 8, 2024
@narefyev91
Copy link
Contributor

@luacmartins @trjExpensify @mallenexpensify PR is ready for review

@trjExpensify
Copy link
Contributor

Let's get it!!

@luacmartins
Copy link
Contributor Author

luacmartins commented Feb 9, 2024

Approved! Just pending C+ review and testing now

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 13, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 13, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Profile] Update name convention from Overview to Profile for all workspace level items like components, functions, routes, etc. [HOLD for payment 2024-02-20] [Simplified Collect][Profile] Update name convention from Overview to Profile for all workspace level items like components, functions, routes, etc. Feb 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 13, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@DylanDylann
Copy link
Contributor

Regression Test Step

On Web (Laptop) and Desktop App

  1. Open any workspace settings
  2. Verify that in the left menu first item is Profile
  3. Verify that top section has naming Profile as well

On mobile:

  1. Open workspace settings
  2. Verify that first menu item is Profile
  3. Click on Profile
  4. Verify that back button is shown with text Profile

Do we agree 👍 or 👎

@trjExpensify
Copy link
Contributor

Waiting out the regression period. We'll be adding tests holistically for this project.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Payment Summary

Upwork Job

  • Contributor: @narefyev91 is from an agency-contributor and not due payment
  • ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@trjExpensify
Copy link
Contributor

@DylanDylann - sent you an offer for $500 for the C+ review.

@trjExpensify
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

5 participants