[HOLD for payment 2024-02-09] [$500] IOU – Failed Split bill lost receipt when go offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.35-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

Precondition:
User have failed Split bill
Steps:

1. Navigate to the failed Split bill chat
2. Go offline
3. Navigate to other chat
4. Come back to the failed Split bill chat

Expected Result:

Failed Split bill receipt should be visible on chat and detailed view

Actual Result:

ailed Split bill receipt is not displayed in offline mode.
Same behavior when open a chat with attachment uploaded and disable the internet connection

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6363879_1706808315814.Recording__1993.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bec8e5af62cb469a
• Upwork Job ID: 1753183814253965312
• Last Price Increase: 2024-02-01

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[francoisl]

Not sure why no one got assigned to this, I'll reapply the label and start looking on the side.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bec8e5af62cb469a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[francoisl]

It might be from #34505 but I can't repro locally, I'll start an ad-hoc build to test more.

[francoisl]

cc @kidroca if you have any idea how #34505 would cause issues with locally cached images while offline.

[kidroca]

cc @kidroca if you have any idea how #34505 would cause issues with locally cached images while offline.

It might be that the images weren't yet cached
As with other images we haven't yet seen they would appear as blank when we try to present them with no internet

I'd like to check this out on staging, to exclude any other issues like CORS

[kidroca]

Hey @kbecciv can you update the reproduction steps and explain how to get in to this "failed split bill" precondition

I’m trying to reproduce and debug the issue, but I don’t understand the section and the precondition

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Image Web/Desktop: Add support for http headers" #35636

If no regressions arise, payment will be issued on 2024-02-09. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests

[francoisl]

Hey kbecciv can you update the reproduction steps and explain how to get in to this "failed split bill" precondition
I’m trying to reproduce and debug the issue, but I don’t understand the section and the precondition

@kidroca for my test steps, I found that you don't even need a failed split bill specifically - any receipt upload will do, regardless of whether it finished scanning or not. Here are steps you can use:

1. Create a workspace. This will create a workspace expense chat between you and the workspace, open it
2. From the Composer, the + option should have a Split Bill option, click that
   
3. Use the Scan option, and upload any image. You should then see a "Scan in progress…" preview in the chat
4. Go offline
5. Switch to any other chat
6. Switch back to the workspace chat with the receipt
   • That's when the receipt image was missing

Hope this helps, let me know if you need any more details.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @slafortune you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @sobitneupane owed $500 via NewDot

BugZero Checklist (@slafortune)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1753183814253965312/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@francoisl, @slafortune, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[francoisl]

This was a deploy blocker that was handled internally, I don't believe any payment is due but let me know if that's wrong.