Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile - Different avatar is displayed before default avatar is displayed when removing profile picture #35570

Closed
3 of 6 tasks
lanitochka17 opened this issue Feb 1, 2024 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.35-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: Account shouldn't have a profile picture when starting testing

  1. Add a profile picture
  2. Remove the profile picture

Expected Result:

Default avatar should be displayed when removing profile picture

Actual Result:

Different profile picture is displayed first then default avatar on removing profile picture

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6363782_1706802379026.Screen_Recording_2024-02-01_at_6.14.27_in_the_evening.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 1, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@tienifr
Copy link
Contributor

tienifr commented Feb 1, 2024

Cannot reproduce this on the latest main.

Screen.Recording.2024-02-02.at.00.05.01.mov

@sobitneupane
Copy link
Contributor

Can you retry with a different email? I can reproduce the issue.

Screen.Recording.2024-02-01.at.22.53.26.mov

@tienifr
Copy link
Contributor

tienifr commented Feb 1, 2024

Did you pull the latest main? I tried with 5 different emails and cannot reproduce with any.

@tienifr
Copy link
Contributor

tienifr commented Feb 1, 2024

With the same emails. I can reproduce on staging but not on main. That's weird.

@sobitneupane
Copy link
Contributor

I am pretty sure, this issue has the same root cause as this one. Discussion on: #35560

@roryabraham
Copy link
Contributor

Not going to treat this as a deploy blocker.

@roryabraham roryabraham added Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 1, 2024
@trjExpensify
Copy link
Contributor

Are we consolidating this one with #35560?

@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@trjExpensify
Copy link
Contributor

Bump on the Q! @tienifr maybe you have an opinion on that?

@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2024
@tienifr
Copy link
Contributor

tienifr commented Feb 5, 2024

Yes I think we can move the discussion to #35560 and close this one.

@trjExpensify
Copy link
Contributor

Cool, sounds good. Going to close this out then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants