Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] BA - Error message for wrong account number does not appear, unexpected error instead #35533

Closed
1 of 6 tasks
lanitochka17 opened this issue Feb 1, 2024 · 19 comments
Closed
1 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.34-1
Reproducible in staging?: Y
Reproducible in production?: Not able to test on production
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4255853
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must be logged in and have created a Workspace

  1. Go to Settings > Workspaces > Select Workspace > Bank account
  2. Select "Connect online with Plaid"
  3. Go trough the add bank account process, select Chase and the account ending with 1111
  4. Enter the Routing number
  5. On the account number field, enter "1111222233334444"
  6. Click on "Continue"

Expected Result:

An error message should be displayed: "Your account number should end with 1111"

Actual Result:

Another error message is displayed: "An unexpected error occurred while trying to add your bank account. Please try again": An unexpected error occurred while trying to add your bank account. Please try again.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362939_1706737360781.bandicam_2024-01-31_14-28-31-607.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01665cdc2655d7f614
  • Upwork Job ID: 1752870011138125824
  • Last Price Increase: 2024-02-01
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01665cdc2655d7f614

@melvin-bot melvin-bot bot changed the title BA - Error message for wrong account number does not appear, unexpected error instead [$500] BA - Error message for wrong account number does not appear, unexpected error instead Feb 1, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@marcaaron
Copy link
Contributor

An error message should be displayed: "Your account number should end with 1111"

confirming: This is the expected behavior? Why would this error say that? 🤔

@marcaaron
Copy link
Contributor

marcaaron commented Feb 1, 2024

Ok error looks like it would be thrown from here. I see @Gonals and @MariaHCD in some git blames (quite old though) so maybe they have some context or an idea about what to look at next.

On first glance, I don't see any changes in the current staging App checklist that might cause this.

@Gonals
Copy link
Contributor

Gonals commented Feb 1, 2024

Ok error looks like it would be thrown from here. I see @Gonals and @MariaHCD in some git blames (quite old though) so maybe they have some context or an idea about what to look at next.

On first glance, I don't see any changes in the current staging App checklist that might cause this.

Heh. That was a while ago 😅. I don't really recall much of it off the top of my head, but I agree this doesn't seem like a blocker

@parasharrajat
Copy link
Member

parasharrajat commented Feb 1, 2024

I am curious why we have to manually enter the routing number and account number when we already fetched those via Plaid and then got the selection from the user.

I agree, it doesn't have to be a deploy blocker.

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

If we decide this is not a deploy blocker, I think we can close this/ put on hold for the bank account flow refactor which will update lots of the patterns here #34498

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

@marcaaron @nkuoch Actually I think Nathalie fixed it with https://github.com/Expensify/Web-Expensify/pull/40755/files

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

Or maybe not that fix is only in the new flow if I see correctly

@nkuoch nkuoch removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 1, 2024
@nkuoch nkuoch self-assigned this Feb 1, 2024
@nkuoch nkuoch added the Daily KSv2 label Feb 1, 2024
@marcaaron
Copy link
Contributor

Ah thanks everyone! ❤️

@nkuoch
Copy link
Contributor

nkuoch commented Feb 1, 2024

Weird, can't reproduce in dev nor staging
image
image

@lanitochka17 What email did you use, so I can check the logs?

@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
Copy link

melvin-bot bot commented Feb 5, 2024

@nkuoch, @johncschuster, @parasharrajat, @marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick!

@lanitochka17
Copy link
Author

@nkuoch Hello
applausetester+vd_web013124@applause.expensifail.com

@johncschuster
Copy link
Contributor

@nkuoch bump!

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
@nkuoch
Copy link
Contributor

nkuoch commented Feb 7, 2024

@lanitochka17 Didn't find anything obvious from the logs, and still cannot reproduce it. @lanitochka17 Are you sure you can reproduce it?

I can't:
https://github.com/Expensify/App/assets/2463975/33db890a-3c15-4168-810d-f22dc88cb074

Closing, please reopen if you can reproduce it.

@nkuoch nkuoch closed this as completed Feb 7, 2024
@lanitochka17
Copy link
Author

@nkuoch Issue is not reproducible

image (19)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants